From: Aniket Gupta <aniketgupta3001@gmail.com>
To: tamird@gmail.com
Cc: git@vger.kernel.org, tao@klerks.biz, gitster@pobox.com,
newren@gmail.com, peff@peff.net, avarab@gmail.com
Subject: Re: [PATCH v3 3/3] ls-files: use and update the untracked cache
Date: Fri, 20 Nov 2026 22:54:20 +0530 [thread overview]
Message-ID: <20261120172420.47728-1-aniketgupta3001@gmail.com> (raw)
In-Reply-To: <20261023-ls-files-untracked-cache-v3-3-292260e95f53@gmail.com>
Hi Tamir,
Thanks for working on this.
> + * With index.skipHash, the checksum cannot detect concurrent index
> + * changes. Lock the index before reading it.
With core.untrackedCache=true and a cold cache this holds index.lock for
the whole scan, so a concurrent git add will fail. With 60k untracked
files, a background "git ls-files -o --exclude-standard" and "git add
new1" 30ms later give
fatal: Unable to create '.git/index.lock': File exists.
master doesnt do this and cmd_status() locks only after collecting. Does
the lock need to be taken before reading? verify_index_from() seems to
handle skipHash and locking after fill_directory() is working except for
the t7519 skiphash test.
prev parent reply other threads:[~2026-11-20 17:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 17:10 [PATCH 0/2] ls-files: reuse the untracked cache Tamir Duberstein
2026-09-23 17:10 ` [PATCH 1/2] dir: hash ignore files before adding parser LF Tamir Duberstein
2026-09-23 17:10 ` [PATCH 2/2] ls-files: reuse cached untracked listings Tamir Duberstein
2026-09-23 18:38 ` [PATCH 0/2] ls-files: reuse the untracked cache Tamir Duberstein
2026-09-23 22:26 ` [PATCH v2 0/3] ls-files: reuse and update " Tamir Duberstein
2026-09-23 22:26 ` [PATCH v2 1/3] dir: hash ignore files before appending newline Tamir Duberstein
2026-09-23 22:26 ` [PATCH v2 2/3] dir: share untracked caches across output modes Tamir Duberstein
2026-09-23 22:27 ` [PATCH v2 3/3] ls-files: use and update the untracked cache Tamir Duberstein
2026-10-23 2:13 ` [PATCH v2 0/3] ls-files: reuse " Tamir Duberstein
2026-10-23 20:03 ` [PATCH v3 " Tamir Duberstein
2026-10-23 20:03 ` [PATCH v3 1/3] dir: hash ignore files before appending newline Tamir Duberstein
2026-10-23 20:03 ` [PATCH v3 2/3] dir: share untracked caches across output modes Tamir Duberstein
2026-10-23 20:03 ` [PATCH v3 3/3] ls-files: use and update the untracked cache Tamir Duberstein
2026-11-20 17:24 ` Aniket Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120172420.47728-1-aniketgupta3001@gmail.com \
--to=aniketgupta3001@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=tamird@gmail.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox