From: William Hatfield <whatfield.git@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Jean-Noël AVILA" <jn.avila@free.fr>,
"Patrick Steinhardt" <ps@pks.im>, "Glen Choo" <glencbz@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 0/3] submodule: foreach in reverse order, with the superproject
Date: Sat, 21 Nov 2026 11:17:55 -0500 [thread overview]
Message-ID: <20261121161755.20032-1-whatfield.git@gmail.com> (raw)
In-Reply-To: <20261028001529.81557-1-whatfield.git@gmail.com>
Hi,
A gentle follow-up on this series. Before I resend, I would like to
know whether the overall design is acceptable.
The one open question is the name --reverse-traversal. Following
Junio's earlier comments about "bottom-up" vs. {pre,in,post}order: it
is not a tree-walk order, so there is no "in-order" counterpart. It
reverses the existing order literally, siblings included, and it means
the same thing with or without --recursive. Unlike in v1, the options
no longer require --recursive. Is that acceptable as a name?
Upstream has moved since: a new t7427 appeared, so I would renumber
mine to t7428, plus a trivial t/meson.build rebase. I'll send that as
v3 once the design is agreed, or in a week or so if there is no
objection.
Thanks,
William
prev parent reply other threads:[~2026-11-21 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 21:43 [PATCH 0/5] submodule: add 'reversive' traversal options to foreach William Hatfield
2026-01-31 21:43 ` [PATCH 1/5] t7425: add tests for reversive submodule traversal William Hatfield
2026-01-31 21:43 ` [PATCH 2/5] submodule: teach and plumb reverse-traversal behavior William Hatfield
2026-01-31 21:43 ` [PATCH 3/5] submodule: teach and plumb append-superproject behavior William Hatfield
2026-01-31 21:43 ` [PATCH 4/5] submodule: introduce reversive shorthand mode William Hatfield
2026-01-31 21:43 ` [PATCH 5/5] doc: document reversive traversal and related modes William Hatfield
2026-02-01 9:03 ` Jean-Noël AVILA
2026-02-02 21:10 ` William Hatfield
2026-02-02 18:52 ` [PATCH 0/5] submodule: add 'reversive' traversal options to foreach Junio C Hamano
2026-02-02 21:02 ` William Hatfield
2026-02-02 21:25 ` Junio C Hamano
2026-10-28 0:15 ` [PATCH v2 0/3] submodule: foreach in reverse order, with the superproject William Hatfield
2026-10-28 0:15 ` [PATCH v2 1/3] submodule: add --reverse-traversal to foreach William Hatfield
2026-10-28 0:15 ` [PATCH v2 2/3] submodule: add --include-superproject " William Hatfield
2026-10-28 0:15 ` [PATCH v2 3/3] submodule: add --reversive shorthand " William Hatfield
2026-11-21 16:17 ` William Hatfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121161755.20032-1-whatfield.git@gmail.com \
--to=whatfield.git@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=glencbz@gmail.com \
--cc=jn.avila@free.fr \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox