From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [GSoC PATCH 2/2] t4018: add tests for gitconfig in userdiff
Date: Sun, 23 Mar 2025 13:08:04 -0300 [thread overview]
Message-ID: <204EB04B-40E5-4D10-8C2F-46D6F2E3F77C@gmail.com> (raw)
In-Reply-To: <Z9vUAzt-5FNgSEKd@pks.im>
> I think it would make sense to suqash this commit into the first one.
Ok! I'll do that in a v2.
> You're missing newlines at the end of al test files. I don't think this
> is intentional, is it?
No... somehow my text editor is not configured to do that. I'll fix it.
prev parent reply other threads:[~2025-03-23 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 17:20 [GSoC PATCH 0/2] add userdiff driver for gitconfig Lucas Seiki Oshiro
2025-03-19 17:20 ` [GSoC PATCH 1/2] userdiff: add builtin driver for gitconfig syntax Lucas Seiki Oshiro
2025-03-20 8:38 ` Patrick Steinhardt
2025-03-21 2:11 ` D. Ben Knoble
2025-03-19 17:20 ` [GSoC PATCH 2/2] t4018: add tests for gitconfig in userdiff Lucas Seiki Oshiro
2025-03-20 8:38 ` Patrick Steinhardt
2025-03-23 16:08 ` Lucas Seiki Oshiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204EB04B-40E5-4D10-8C2F-46D6F2E3F77C@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).