* Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files
@ 2012-10-17 17:04 Thomas Ackermann
2012-10-17 20:24 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Ackermann @ 2012-10-17 17:04 UTC (permalink / raw)
To: gitster, th.acker66; +Cc: git, philipoakley, peff, git
----- Original Nachricht ----
Von: Junio C Hamano <gitster@pobox.com>
An: Thomas Ackermann <th.acker66@arcor.de>
Datum: 17.10.2012 00:11
Betreff: Re: [Patch v3 0/8] Create single PDF for all HTML files
>
> I (and other people who wrote documentation, I suspect, as well)
> feel somewhat offended by the word "fix" here and there in the
> message in commits that turn files that so far have been plain text
> into asciidoc, though ;-).
>
When I started working on this topic, I was wondering why not all files in ./technical and ./howto
where converted to html. So I tried it myself and found out, that only minor changes where needed
to get them processed by asciidoc. So from my perspective I was simply "fixing some asciidoc problems".
But of course this wording was never meant to offend anybody. Sorry for that.
BTW1: As only the changes in the doc files where cherry-picked, currently on pu howto-index.sh
will create invalid links in howto-index.html because it scans all .txt-files in ./howto for
'Content-type: text/asciidoc' and if found, creates a reference to a html file. But these are not created
for the new asciidoc files. So the changes in Documentation/Makefile which create html for the new
files should be merged also.
BTW2: The 'pretty-print shell script in update-hook-example.txt' part of my changes was left out
from the merge to pu but should also be considered as belonging to the category 'convert plain text files to asciidoc'
as the original file contained a mixture of tabs and spaces which caused suboptimal indendation formatting
with asciidoc.
---
Thomas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files
2012-10-17 17:04 Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files Thomas Ackermann
@ 2012-10-17 20:24 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2012-10-17 20:24 UTC (permalink / raw)
To: Thomas Ackermann; +Cc: git, philipoakley, peff, git
Thomas Ackermann <th.acker66@arcor.de> writes:
> BTW1: As only the changes in the doc files where cherry-picked, currently on pu howto-index.sh
> will create invalid links in howto-index.html because it scans all .txt-files in ./howto for
> 'Content-type: text/asciidoc' and if found, creates a reference to a html file. But these are not created
> for the new asciidoc files. So the changes in Documentation/Makefile which create html for the new
> files should be merged also.
Ah, I didn't notice that.
That means that for the patch [6/8], which adds content-type to the
text files, to be complete, it needs to update Makefile to produce
html files from them.
Thanks.
> BTW2: The 'pretty-print shell script in update-hook-example.txt'
> part of my changes was left out from the merge to pu ...
Do you mean e2399e9 (Documentation/howto: convert plain text files
to asciidoc, 2012-10-16), or something else?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-17 20:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-17 17:04 Aw: Re: [Patch v3 0/8] Create single PDF for all HTML files Thomas Ackermann
2012-10-17 20:24 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).