From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>,
Git List <git@vger.kernel.org>,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2] fetch-pack: parameterize message containing 'ready' keyword
Date: Thu, 18 Nov 2021 14:21:33 +0100 [thread overview]
Message-ID: <211118.864k8961hw.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <CAPig+cTKNYCoiRiDyi-KxxvheiYJ4rAxFY7vHx-r+qNyXYHNjA@mail.gmail.com>
On Thu, Nov 18 2021, Eric Sunshine wrote:
> On Thu, Nov 18, 2021 at 5:35 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>> The protocol keyword 'ready' isn't meant for translation. Pass it as
>> parameter instead of spell it in die() message (and potentially confuse
>> translators).
>>
>> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
>> ---
>> diff --git a/fetch-pack.c b/fetch-pack.c
>> @@ -1410,9 +1410,13 @@ static int process_ack(struct fetch_negotiator *negotiator,
>> if (*received_ready && reader->status != PACKET_READ_DELIM)
>> - die(_("expected packfile to be sent after 'ready'"));
>> + /* TRANSLATORS: The parameter will be 'ready', a protocol
>> + * keyword */
>> + die(_("expected packfile to be sent after '%s"), "ready");
>
> Missing closing single-quote after %s.
>
>> if (!*received_ready && reader->status != PACKET_READ_FLUSH)
>> - die(_("expected no other sections to be sent after no 'ready'"));
>> + /* TRANSLATORS: The parameter will be 'ready', a protocol
>> + * keyword */
>> + die(_("expected no other sections to be sent after no '%s"), "ready");
>
> Missing closing single-quote after %s.
Also s/be sent after no/be sent after/, i.e. there's a stray "no".
prev parent reply other threads:[~2021-11-18 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 10:34 [PATCH v2] fetch-pack: parameterize message containing 'ready' keyword Bagas Sanjaya
2021-11-18 11:42 ` Eric Sunshine
2021-11-18 13:21 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211118.864k8961hw.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).