git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jose Wielandt <jose.wielandt@timining.com>,
	Fabian Stelzer <fs@gigacodes.de>, git <git@vger.kernel.org>
Subject: Re: Please, paint new branch errors in RED (or any visible color)
Date: Sun, 12 Dec 2021 20:01:34 +0100	[thread overview]
Message-ID: <211212.86o85labj1.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq4k7dlld3.fsf@gitster.g>


On Sun, Dec 12 2021, Junio C Hamano wrote:

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> On Fri, Dec 10 2021, Jose Wielandt wrote:
>>
>>> Yes, I git switch has the same behavior.
>>> I also agree that add hints could be a good idea.
>>
>> I'll pick up this topic.
>
> Please make sure color challenged users can configure it away or
> customize it somehow.

Yes, I think it's a bug if we add any such coloring that isn't
configurable via the usual color.* configuration. Although in this case
it's usage.c. So perhaps "color.usage" (as in usage.c). But that squats
on any future hypothetical "git usage". So maybe "color.coreUsage" (a
"color.core.usage" would squat on any future "color.core.usage.<slot>"
(i.e. there's no 4-level keys)>

> Making it opt-in is even better, but it is my personal taste.

*nod*. I'll see how it turns out. FWIW I think that it's probably too
over-colored to do:

    <RED>fatal: the message</RED>

And it's probably better to just do:

    <RED>fatal</RED>: the message

But I'll see once we have actual examples. The advice output is
fully-colored now. I.e. "hint: message", not just the "hint" part...

  reply	other threads:[~2021-12-12 19:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 11:36 Please, paint new branch errors in RED (or any visible color) Jose Wielandt
2021-12-10 16:32 ` Ævar Arnfjörð Bjarmason
2021-12-10 16:42   ` Fabian Stelzer
2021-12-10 19:09     ` Jose Wielandt
2021-12-11  2:30       ` Ævar Arnfjörð Bjarmason
2021-12-12 18:38         ` Junio C Hamano
2021-12-12 19:01           ` Ævar Arnfjörð Bjarmason [this message]
2021-12-12 22:27             ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=211212.86o85labj1.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=fs@gigacodes.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jose.wielandt@timining.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).