git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Bash <bash@genarts.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>,
	Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: Effectively navigating branch history
Date: Tue, 31 May 2011 14:51:15 -0400 (EDT)	[thread overview]
Message-ID: <21849336.45230.1306867875224.JavaMail.root@mail.hq.genarts.com> (raw)
In-Reply-To: <7vtycaiuh9.fsf@alter.siamese.dyndns.org>

----- Original Message -----
> From: "Junio C Hamano" <gitster@pobox.com>
> Sent: Tuesday, May 31, 2011 2:40:50 PM
> Subject: Re: Effectively navigating branch history
> 
> >> Yeah, I think it was 1f9a980636 which was a merge between fb674d7
> >> and 73546c0. I just compared the output between these two:
> >>
> >> $ git diff fb674d7...73546c0 -- config.c ;# what the topic did
> >> $ git diff fb674d7 1f9a980 -- config.c ;# what was merged
> >
> > I often find myself wanting to do the "what the topic did" operation
> > but once the branch is merged and deleted, I have difficulty finding
> > useful SHAs to diff.
> >
> > So in an attempt to educate myself, I tried to track down fb674d7
> > and 1f9a980 (and failed miserably).
> 
> I just did
> 
> $ git log --first-parent master -- config.c
> 
> which was sufficient for my workflow as most of the commits on master
> are merges from topics and I can see what each topic did from the merge
> commit summary message.

Ah, if only our workflow made it that easy... unfortunately it does not ;)

> If I were doing this on a codebase I am not very familiar with, I
> probably I would have first narrowed things down a bit by
> 
> $ git grep -n -e NOGLOBAL -- config.c ;# to learn the line number 830
> $ git blame -L825,835 -- config.c
> 
> to learn where the offending NOGLOBAL came from (it is from ab88c363)
> so that I can say
> 
> $ git log -m -p -GNOGLOBAL ab88c363.. -- config.c
> 
> to find that 1f9a980 reintroduced it by mistake.

Ah, I was missing the -m!  At one point I realized pickaxe was only showing me non-merge commits and skimmed the log manpage to see if there was an option that would enable it but apparently missed -m.

Thanks!

Stephen

      reply	other threads:[~2011-05-31 18:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 17:23 [PATCH] config.c: Remove unused git_config_global() function Ramsay Jones
2011-05-31 17:51 ` Junio C Hamano
2011-05-31 18:21   ` Effectively navigating branch history (was: Re: [PATCH] config.c: Remove unused git_config_global() function) Stephen Bash
2011-05-31 18:40     ` Effectively navigating branch history Junio C Hamano
2011-05-31 18:51       ` Stephen Bash [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21849336.45230.1306867875224.JavaMail.root@mail.hq.genarts.com \
    --to=bash@genarts.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).