From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Max Kirillov <max@max630.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH/RFC 1/2] sha1_file: close all pack files after running
Date: Sun, 04 Oct 2015 16:53:30 +0200 [thread overview]
Message-ID: <21bd1c9c394a421bc06c6fa1837f16b6@dscho.org> (raw)
In-Reply-To: <20151002192148.GD26154@wheezy.local>
Hi Max,
On 2015-10-02 21:21, Max Kirillov wrote:
> On Fri, Oct 02, 2015 at 12:13:40PM +0200, Johannes Schindelin wrote:
>> On 2015-10-02 12:05, Johannes Schindelin wrote:
>>
>> > On 2015-10-01 05:29, Max Kirillov wrote:
>>>> When a builtin has done its job, but waits for pager or not waited
>>>> by its caller and still hanging it keeps pack files opened.
>>>> This can cause a number of issues, for example on Windows git gc
>>>> cannot remove the packs.
>>
>> Could you do me another favor? It seems that you want to
>> work on this, so I will step back (I have to take off for
>> the weekend very soon anyway, so I am really glad that you
>> take care of it). But I would really love to see the line
>
> As I explained in other message, your case is a bit
> different.
I guess then we would need two different patches for the two different fixes, at least.
So now I am unsure how to proceed: I do not want to step on your toes, but I also want to see my use case fixed and I want to move forward on this. At the moment, it looks as if we are at an impasse.
Ciao,
Johannes
next prev parent reply other threads:[~2015-10-04 14:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 19:44 [PATCH] clone --dissociate: avoid locking pack files Johannes Schindelin
2015-09-30 19:28 ` Max Kirillov
2015-09-30 19:42 ` Junio C Hamano
2015-10-01 3:29 ` [PATCH/RFC 0/2] close packs files when they are not needed Max Kirillov
2015-10-01 3:29 ` [PATCH/RFC 1/2] sha1_file: close all pack files after running Max Kirillov
2015-10-02 10:05 ` Johannes Schindelin
2015-10-02 10:13 ` Johannes Schindelin
2015-10-02 19:21 ` Max Kirillov
2015-10-04 14:53 ` Johannes Schindelin [this message]
2015-10-05 4:57 ` Max Kirillov
2015-10-05 9:03 ` Johannes Schindelin
2015-10-02 19:06 ` Max Kirillov
2015-10-02 20:06 ` Max Kirillov
2015-10-01 3:29 ` [PATCH/RFC 2/2] sha1_file: set packfile to O_CLOEXEC at open Max Kirillov
2015-10-02 10:08 ` Johannes Schindelin
2015-10-01 4:39 ` [PATCH] clone --dissociate: avoid locking pack files Max Kirillov
2015-10-05 18:32 ` Johannes Schindelin
2015-10-05 20:29 ` [PATCH v2 0/4] Fix locking issues on Windows with `git clone --dissociate` Johannes Schindelin
2015-10-05 20:29 ` [PATCH v2 1/4] Demonstrate a Windows file locking issue " Johannes Schindelin
2015-10-05 20:30 ` [PATCH v2 2/4] Consolidate code to close a pack's file descriptor Johannes Schindelin
2015-10-05 20:57 ` Junio C Hamano
2015-10-05 21:52 ` Johannes Schindelin
2015-10-05 22:15 ` Junio C Hamano
2015-10-06 13:42 ` Johannes Schindelin
2015-10-05 20:33 ` [PATCH v2 3/4] Add a function to release all packs Johannes Schindelin
2015-10-05 20:33 ` [PATCH v2 4/4] clone --dissociate: avoid locking pack files Johannes Schindelin
2015-10-05 21:00 ` Junio C Hamano
2015-10-06 13:17 ` [PATCH v3 0/4] Fix locking issues on Windows with `git clone --dissociate` Johannes Schindelin
2015-10-06 13:18 ` [PATCH v3 1/4] Demonstrate a Windows file locking issue " Johannes Schindelin
2015-10-06 13:18 ` [PATCH v3 2/4] Consolidate code to close a pack's file descriptor Johannes Schindelin
2015-10-06 13:18 ` [PATCH v3 3/4] Add a function to release all packs Johannes Schindelin
2015-10-07 17:49 ` Junio C Hamano
2015-10-08 19:10 ` Johannes Schindelin
2015-10-06 13:18 ` [PATCH v3 4/4] clone --dissociate: avoid locking pack files Johannes Schindelin
2015-10-11 10:45 ` [PATCH v3 0/4] Fix locking issues on Windows with `git clone --dissociate` Max Kirillov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21bd1c9c394a421bc06c6fa1837f16b6@dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=max@max630.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).