git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 3/4] t3301: fix confusing test for valid notes ref
Date: Sat, 14 Feb 2009 20:15:05 +0100	[thread overview]
Message-ID: <21cefcfb71849535430c75575a9decf1f9fe9c06.1234638466.git.trast@student.ethz.ch> (raw)
In-Reply-To: <b36bbe2f7f0ede6a2caa47190ada868dd4c0099c.1234638466.git.trast@student.ethz.ch>

The test used single quotes in the test code, but also single quotes
to wrap the entire test snippet, thus effectively skipping _out_ of
quoted mode.  Since it doesn't matter here, just drop the quotes to
cause less confusion.

Also, the test passed a MSG variable to 'git notes show', but that
never calls an editor.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---

As an aside, is there a specific reason why all the negative tests use
'! VAR=foo bar' instead of 'VAR=foo test_must_fail bar'?  I thought
the latter was preferred to catch segfaults.


 t/t3301-notes.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh
index ff4ea05..b99271e 100755
--- a/t/t3301-notes.sh
+++ b/t/t3301-notes.sh
@@ -31,8 +31,8 @@ test_expect_success setup '
 '
 
 test_expect_success 'need valid notes ref' '
-	! MSG=1 GIT_NOTES_REF='/' git notes edit &&
-	! MSG=2 GIT_NOTES_REF='/' git notes show
+	! MSG=1 GIT_NOTES_REF=/ git notes edit &&
+	! GIT_NOTES_REF=/ git notes show
 '
 
 # 1 indicates caught gracefully by die, 128 means git-show barked
-- 
1.6.2.rc0.288.g6852b

  parent reply	other threads:[~2009-02-14 19:17 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-14 19:15 [PATCH 1/4] notes: only clean up message file when editing Thomas Rast
2009-02-14 19:15 ` [PATCH 2/4] notes: use GIT_EDITOR and core.editor over VISUAL/EDITOR Thomas Rast
2009-02-14 19:29   ` Johannes Schindelin
2009-02-14 19:15 ` Thomas Rast [this message]
2009-02-14 19:32   ` [PATCH 3/4] t3301: fix confusing test for valid notes ref Johannes Schindelin
2009-02-14 19:15 ` [PATCH 4/4] notes: refuse to edit notes outside refs/notes/ Thomas Rast
2009-02-14 19:33   ` Johannes Schindelin
2009-02-14 19:56     ` Thomas Rast
2009-02-14 20:23       ` [PATCH v2 1/5] notes: only clean up message file when editing Thomas Rast
2009-02-15  7:54         ` Junio C Hamano
2009-02-14 20:23       ` [PATCH v2 2/5] notes: use GIT_EDITOR and core.editor over VISUAL/EDITOR Thomas Rast
2009-02-14 20:23       ` [PATCH v2 3/5] t3301: fix confusing quoting in test for valid notes ref Thomas Rast
2009-02-14 20:23       ` [PATCH v2 4/5] t3301: use test_must_fail instead of ! Thomas Rast
2009-02-14 21:26         ` Johannes Schindelin
2009-02-15  7:52         ` Junio C Hamano
2009-02-15 16:11           ` Thomas Rast
2009-02-15 18:18             ` Jeff King
2009-02-15 22:07               ` Thomas Rast
2009-02-17  9:29               ` Mike Ralphson
2009-02-17 16:34                 ` Jeff King
2009-02-17 18:00                   ` Mike Ralphson
2009-02-17 20:27                     ` Jeff King
2009-02-18  6:41                       ` Jeff King
2009-02-18 10:14                         ` Johannes Schindelin
2009-02-18 10:16                           ` Jeff King
2009-02-18 11:53                             ` Johannes Schindelin
2009-02-19  0:37                               ` Jeff King
2009-02-19  0:46                                 ` Johannes Schindelin
2009-02-19  0:46                                   ` Jeff King
2009-02-17  8:44           ` Thomas Rast
2009-02-17  8:46             ` Thomas Rast
2009-02-17 16:56               ` Brandon Casey
2009-02-17 22:20                 ` Junio C Hamano
2009-02-17 22:53                   ` [PATCH] test suite: correct export var=val usage Jay Soffian
2009-02-17 23:47                     ` Johannes Schindelin
2009-02-18  0:37                       ` Jay Soffian
2009-02-17 22:54                   ` Jay Soffian
2009-02-17 22:57                   ` Jay Soffian
2009-02-18 10:06                     ` Wincent Colaiuta
2009-02-18 13:19                       ` Jay Soffian
2009-02-18 13:29                         ` Jay Soffian
2009-02-18 13:34                           ` Johannes Schindelin
2009-02-18 16:56                           ` Wincent Colaiuta
2009-02-18 17:05                             ` Thomas Rast
2009-02-18 20:55                   ` [PATCH v2] " Jay Soffian
2009-02-14 20:23       ` [PATCH v2 5/5] notes: refuse to edit notes outside refs/notes/ Thomas Rast
2009-02-14 19:29 ` [PATCH 1/4] notes: only clean up message file when editing Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21cefcfb71849535430c75575a9decf1f9fe9c06.1234638466.git.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).