public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jean-Noël Avila" <avila.jn@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 2/2] bisect: document command line arguments for "bisect start"
Date: Thu, 8 Feb 2024 17:18:54 +0100	[thread overview]
Message-ID: <21ec33d4-4036-4763-9117-fbbdca1e2273@gmail.com> (raw)
In-Reply-To: <20240207214436.538586-3-gitster@pobox.com>

Le 07/02/2024 à 22:44, Junio C Hamano a écrit :
> The syntax commonly used for alternatives is --opt-(a|b), not
> --opt-{a,b}.
>
> List bad/new and good/old consistently in this order, to be
> consistent with the description for "git bisect terms".  Clarify
> <term> to either <term-old> or <term-new> to make them consistent
> with the description of "git bisect (good|bad)" subcommands.
>
> Suggested-by: Matthieu Moy <git@matthieu-moy.fr>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>   Documentation/git-bisect.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt
> index 3d813f9c77..73f889b97b 100644
> --- a/Documentation/git-bisect.txt
> +++ b/Documentation/git-bisect.txt
> @@ -16,7 +16,7 @@ DESCRIPTION
>   The command takes various subcommands, and different options depending
>   on the subcommand:
>   
> - git bisect start [--term-{new,bad}=<term> --term-{old,good}=<term>]
> + git bisect start [--term-(bad|new)=<term-new> --term-(good|old)=<term-old>]
>   		  [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<paths>...]
>    git bisect (bad|new|<term-new>) [<rev>]
>    git bisect (good|old|<term-old>) [<rev>...]


LGTM


  reply	other threads:[~2024-02-08 16:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09 11:58 [BUG] git-bisect man page description of terms command doesn't mention old/new support Britton Kerin
2023-12-09 16:13 ` Re* " Junio C Hamano
2023-12-11 12:34   ` Matthieu Moy
2023-12-11 15:05     ` Junio C Hamano
2024-02-07 21:44     ` [PATCH 0/2] minute "git bisect" doc updates Junio C Hamano
2024-02-07 21:44       ` [PATCH 1/2] bisect: document "terms" subcommand more fully Junio C Hamano
2024-02-08  6:36         ` Kristoffer Haugsbakk
2024-02-08 16:48           ` Junio C Hamano
2024-02-07 21:44       ` [PATCH 2/2] bisect: document command line arguments for "bisect start" Junio C Hamano
2024-02-08 16:18         ` Jean-Noël Avila [this message]
2024-02-09  9:39       ` [PATCH 0/2] minute "git bisect" doc updates Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21ec33d4-4036-4763-9117-fbbdca1e2273@gmail.com \
    --to=avila.jn@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox