git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Jean-Noël AVILA" <jn.avila@free.fr>
Subject: ja/i18n-common-messages (was: What's cooking in git.git (Feb 2022, #04; Tue, 15))
Date: Tue, 15 Feb 2022 23:17:56 +0100	[thread overview]
Message-ID: <220215.865ypfwz2q.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqk0dwyrcv.fsf@gitster.g>


On Tue, Feb 15 2022, Junio C Hamano wrote:

> * ja/i18n-common-messages (2022-02-04) 4 commits
>  - i18n: fix some misformated placeholders in command synopsis
>  - i18n: remove from i18n strings that do not hold translatable parts
>  - i18n: factorize "invalid value" messages
>  - i18n: factorize more 'incompatible options' messages
>
>  Unify more messages to help l10n.
>
>  Will merge to 'next'?
>  source: <pull.1123.v4.git.1643666870.gitgitgadget@gmail.com>

The changes to messages etc. in this series and the previous ones all
look good.

The one reservation I had about it was the addition to the
parse-options.c API:
https://lore.kernel.org/git/220201.86a6fa9tmr.gmgdl@evledraar.gmail.com/

I don't mind if this goes in as-is, but would really like us to give
ourselves license to make some generalized parse-options.c feature (like
the OPT_INCOMPATIBLE() I proposed in the linked thread) not need to have
the semantics introduced in die_for_incompatible_opt3() and
die_for_incompatible_opt4() in this series.

I.e. it's a lot simpler to just die with a message the first time we see
that --opt-b doesn't go with --opt-a, instead of needing to continue
parsing and finding that --opt-c is also incompatible with the two, etc.

  reply	other threads:[~2022-02-15 22:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 17:25 What's cooking in git.git (Feb 2022, #04; Tue, 15) Junio C Hamano
2022-02-15 22:17 ` Ævar Arnfjörð Bjarmason [this message]
2022-02-15 22:22 ` ab/ambiguous-object-name & ab/only-single-progress-at-once (was: What's cooking in git.git (Feb 2022, #04; Tue, 15)) Ævar Arnfjörð Bjarmason
2022-02-16  4:52 ` en/present-despite-skipped (Was: " Elijah Newren
2022-02-16  9:44   ` Ævar Arnfjörð Bjarmason
2022-02-16 16:38     ` Elijah Newren
2022-02-16  5:01 ` js/apply-partial-clone-filters-recursively " Elijah Newren
2022-02-16  5:06 ` ds/sparse-checkout-requires-per-worktree-config " Elijah Newren
2022-02-16 13:54   ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220215.865ypfwz2q.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jn.avila@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).