From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Elijah Newren <newren@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: en/present-despite-skipped (Was: Re: What's cooking in git.git (Feb 2022, #04; Tue, 15))
Date: Wed, 16 Feb 2022 10:44:45 +0100 [thread overview]
Message-ID: <220216.867d9vuorn.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <CABPp-BFOw48k0M3U+fef1J57wHt2uq4hbKo-vnjAj56nYY6m2Q@mail.gmail.com>
On Tue, Feb 15 2022, Elijah Newren wrote:
> On Tue, Feb 15, 2022 at 12:01 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> * en/present-despite-skipped (2022-01-14) 6 commits
>> - Accelerate clear_skip_worktree_from_present_files() by caching
>> - Update documentation related to sparsity and the skip-worktree bit
>> - repo_read_index: clear SKIP_WORKTREE bit from files present in worktree
>> - unpack-trees: fix accidental loss of user changes
>> - t1011: add testcase demonstrating accidental loss of user modifications
>> - Merge branch 'vd/sparse-clean-etc' into en/present-despite-skipped
>> (this branch uses vd/sparse-clean-etc.)
>>
>> In sparse-checkouts, files mis-marked as missing from the working tree
>> could lead to later problems. Such files were hard to discover, and
>> harder to correct. Automatically detecting and correcting the marking
>> of such files has been added to avoid these problems.
>>
>> Will merge to 'next'?
>> cf. <20220204081336.3194538-1-newren@gmail.com>
>> source: <pull.1114.v2.git.1642175983.gitgitgadget@gmail.com>
>
> Is there anything specific you're looking for here?
>
> I think it's ready, as I said two weeks ago in the link you provided
> above. All reviewer feedback was addressed to reviewers' satisfaction
> over a month ago, so I'm not sure what else to do here...
FWIW I gave it some light reading just now & left some comments on it.
I don't think any of them should be blocking on it being merged down to
"next", but perhaps some of them suggest worthwhile follow-ups. In
particular the suggested documentation changes & the behavior/error
checking around the lstat() and index iteration in the new path_found().
next prev parent reply other threads:[~2022-02-16 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 17:25 What's cooking in git.git (Feb 2022, #04; Tue, 15) Junio C Hamano
2022-02-15 22:17 ` ja/i18n-common-messages (was: What's cooking in git.git (Feb 2022, #04; Tue, 15)) Ævar Arnfjörð Bjarmason
2022-02-15 22:22 ` ab/ambiguous-object-name & ab/only-single-progress-at-once " Ævar Arnfjörð Bjarmason
2022-02-16 4:52 ` en/present-despite-skipped (Was: " Elijah Newren
2022-02-16 9:44 ` Ævar Arnfjörð Bjarmason [this message]
2022-02-16 16:38 ` Elijah Newren
2022-02-16 5:01 ` js/apply-partial-clone-filters-recursively " Elijah Newren
2022-02-16 5:06 ` ds/sparse-checkout-requires-per-worktree-config " Elijah Newren
2022-02-16 13:54 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220216.867d9vuorn.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).