From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: ab/commit-plug-leaks + ab/diff-free-more (was: What's cooking in git.git (Feb 2022, #06; Wed, 23))
Date: Thu, 24 Feb 2022 10:08:59 +0100 [thread overview]
Message-ID: <220224.86k0dkaaun.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq1qztortk.fsf@gitster.g>
On Wed, Feb 23 2022, Junio C Hamano wrote:
> * ab/commit-plug-leaks (2022-02-16) 2 commits
> - commit: use strbuf_release() instead of UNLEAK()
> - commit: fix "author_ident" leak
>
> Leakfixes in the top-level called-once function.
>
> Expecting a reroll.
> I think UNLEAK->strbuf_release() is a regression.
> source: <cover-0.2-00000000000-20220216T081844Z-avarab@gmail.com>
After you noted that in [1] I followed-up in [2] giving reasons for
wanting to keep that UNLEAK->strbuf_release() change. What do you think
about that?
> * ab/diff-free-more (2022-02-16) 2 commits
> (merged to 'next' on 2022-02-17 at be8ae78a2d)
> + diff.[ch]: have diff_free() free options->parseopts
> + diff.[ch]: have diff_free() call clear_pathspec(opts.pathspec)
>
> Leakfixes.
>
> Will merge to 'master'.
> source: <cover-0.2-00000000000-20220216T105250Z-avarab@gmail.com>
Thanks! It will be great to have this merged down!
1. https://lore.kernel.org/git/xmqqwnhs11he.fsf@gitster.g/
2. https://lore.kernel.org/git/220218.86fsoggdou.gmgdl@evledraar.gmail.com
next prev parent reply other threads:[~2022-02-24 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 3:40 What's cooking in git.git (Feb 2022, #06; Wed, 23) Junio C Hamano
2022-02-24 9:08 ` Ævar Arnfjörð Bjarmason [this message]
2022-02-24 23:38 ` ab/commit-plug-leaks + ab/diff-free-more Junio C Hamano
2022-02-24 9:11 ` ab/c99 + ab/hook-tests (was: What's cooking in git.git (Feb 2022, #06; Wed, 23)) Ævar Arnfjörð Bjarmason
2022-02-24 9:18 ` ab/object-file-api-updates " Ævar Arnfjörð Bjarmason
2022-02-24 17:48 ` ar/submodule-update (wa " Glen Choo
2022-02-24 19:55 ` Junio C Hamano
2022-02-24 19:11 ` jc/cat-file-batch-commands (was: " John Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220224.86k0dkaaun.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).