From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, John Cai <johncai86@gmail.com>
Subject: jc/stash-drop (was: What's cooking in git.git (Mar 2022, #01; Thu, 3))
Date: Sat, 05 Mar 2022 15:25:19 +0100 [thread overview]
Message-ID: <220305.86y21o327b.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqv8wu2vag.fsf@gitster.g>
On Thu, Mar 03 2022, Junio C Hamano wrote:
> * jc/stash-drop (2022-03-02) 3 commits
> - stash: call reflog_delete() in reflog.c
> - reflog: libify delete reflog function and helpers
> - stash: add tests to ensure reflog --rewrite --updatref behavior
>
> "git stash drop" is reimplemented as an internal call to
> reflog_delete() function, instead of invoking "git reflog delete"
> via run_command() API.
>
> Will merge to 'next'?
> source: <pull.1218.v4.git.git.1646260044.gitgitgadget@gmail.com>
I've been reviewing this closely & it looks good to me, all feedback has
been addressed, and there's nothing outstanding (there's one sub-thread
on v4 answering a question from Phillip Wood asking if the new test
needs REFFILES, it does).
next prev parent reply other threads:[~2022-03-05 14:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 4:31 What's cooking in git.git (Mar 2022, #01; Thu, 3) Junio C Hamano
2022-03-04 13:25 ` ab/plug-random-leaks (was Re: What's cooking in git.git (Mar 2022, #01; Thu, 3)) Derrick Stolee
2022-03-04 18:33 ` Ævar Arnfjörð Bjarmason
2022-03-17 12:46 ` [PATCH] tests: test show --word-diff --color-moved Michael J Gruber
2022-03-17 14:55 ` [PATCH v2 0/2] diff.c: fix a recent memory leak regression Ævar Arnfjörð Bjarmason
2022-03-17 14:55 ` [PATCH v2 1/2] tests: demonstrate "show --word-diff --color-moved" regression Ævar Arnfjörð Bjarmason
2022-03-17 15:54 ` Junio C Hamano
2022-03-17 14:55 ` [PATCH v2 2/2] diff.c: fix a double-free regression in a18d66cefb Ævar Arnfjörð Bjarmason
2022-03-04 15:35 ` tb/cruft-packs (was Re: What's cooking in git.git (Mar 2022, #01; Thu, 3)) Derrick Stolee
2022-03-07 18:06 ` Jonathan Nieder
2022-03-07 18:18 ` Taylor Blau
2022-03-07 18:32 ` Derrick Stolee
2022-03-07 20:18 ` Jonathan Nieder
2022-03-07 20:51 ` Derrick Stolee
2022-03-07 21:34 ` Junio C Hamano
2022-03-08 0:52 ` Taylor Blau
2022-03-08 0:25 ` Junio C Hamano
2022-03-08 0:49 ` Taylor Blau
2022-03-05 14:25 ` Ævar Arnfjörð Bjarmason [this message]
2022-03-07 18:22 ` jc/stash-drop Junio C Hamano
2022-03-07 13:49 ` ds/commit-graph-gen-v2-fixes (was Re: What's cooking in git.git (Mar 2022, #01; Thu, 3)) Derrick Stolee
2022-03-07 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220305.86y21o327b.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).