From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Garrit Franke <garrit@slashdev.space>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Taylor Blau <ttaylorr@github.com>
Subject: Re: [PATCH v2] cli: add -v and -h shorthands
Date: Thu, 31 Mar 2022 02:07:06 +0200 [thread overview]
Message-ID: <220331.86tubfrngz.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <fb915b91-ead2-ac35-4431-ad35674da463@slashdev.space>
On Thu, Mar 31 2022, Garrit Franke wrote:
> On Wed, Mar 30 2022, Junio C Hamano wrote:
>
>> Sorry, but it is unclear why it is a good thing.
>
> My main motivation behind this change was a standardized user
> experience across tools. Many users use these shorthands out of habit
> to get an overview of a program. Seeing the command fail and having to
> retype it in a longer form creates unnecessary friction between the
> user and the program.
I think this is a good trade-off in this case. I.e. -v and -h are
commonly understood.
>> Again, it might be safe right now, but it also closes the door for
>> introducing global "verbose" option. What in exchange are we
>> gaining? Are these short options worth it?
>
> I definitely see your concerns. Ultimately it's a question of which of
> the two flags would be more convinient to have as a shorthand. As
> stated above, users unfamiliar to the software arguably expect to see
> the version number printed when using this flag. A user who seeks more
> verbose output is probably more familiar with the options, so they are
> more likely to know they have to use the longer "--verbose" form.
This was somewhat discussed in/around
https://lore.kernel.org/git/87zgs593ja.fsf@evledraar.gmail.com/,
i.e. there I was arguing the counter-point, that we should have things
like "git --no-progress subcmd <opts>", rather than just "git subcmd
--no-progress <other-opts>".
But I think the alternative won the day (at least in that commit-graph
case), and in retrospect I think it was the right call for our UI in
general.
I still think it makes sense for git to understand a thing like
--object-format at the top-level, and maybe/probably --progress, but
--verbose is probably too confusing. I.e. it would imply verbose output
for all commands (which they're much less likely to have/provide than
the other two).
next prev parent reply other threads:[~2022-03-31 0:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 19:09 [PATCH v2] cli: add -v and -h shorthands Garrit Franke
2022-03-30 21:53 ` Junio C Hamano
2022-03-30 22:50 ` Garrit Franke
2022-03-31 0:07 ` Ævar Arnfjörð Bjarmason [this message]
2022-03-31 13:08 ` Garrit Franke
2022-03-31 20:07 ` Junio C Hamano
2022-04-01 9:23 ` Ævar Arnfjörð Bjarmason
2022-04-01 16:02 ` Junio C Hamano
2022-04-04 7:18 ` Garrit Franke
2022-04-04 16:19 ` Junio C Hamano
2022-03-31 21:27 ` [PATCH v3] " Garrit Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220331.86tubfrngz.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=garrit@slashdev.space \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ttaylorr@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).