From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] repack: document there is no need to avoid delta-base-offset
Date: Tue, 19 Jul 2022 23:54:18 +0200 [thread overview]
Message-ID: <220719.86h73cvkbw.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqqbktk93kl.fsf_-_@gitster.g>
On Tue, Jul 19 2022, Junio C Hamano wrote:
> As continued use of 1.4.4 by people stopped being an issue long time
> ago, we can safely remove the warning about interoperability that we
> added in 1.6.0 when the use of delta-base-offset has become default.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> * Instead of outright removing, it probably is a good idea to hint
> the reason why the now seemingly useless configuration variable
> is there, perhaps.
We cover that in git-config(1), I don't see a reason to continue
dicsussing it in git-repack(1) as well. Just above the paragraph you're
modifying we link to it.
The patch you've got here also replaces a specific reason (pre-1.4.4)
with a vague reference to "hardly any reason", leaving the reader
wondering what that reason is...
next prev parent reply other threads:[~2022-07-19 21:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 7:51 [PATCH] git-repack doc: remove discussion of ancient caveat Ævar Arnfjörð Bjarmason
2022-07-15 16:53 ` Junio C Hamano
2022-07-16 7:59 ` Ævar Arnfjörð Bjarmason
2022-07-18 5:14 ` Junio C Hamano
2022-07-18 7:35 ` Ævar Arnfjörð Bjarmason
2022-07-19 1:16 ` Junio C Hamano
2022-07-19 9:07 ` Ævar Arnfjörð Bjarmason
2022-07-19 21:48 ` [PATCH] repack: document there is no need to avoid delta-base-offset Junio C Hamano
2022-07-19 21:54 ` Ævar Arnfjörð Bjarmason [this message]
2022-07-19 22:20 ` Junio C Hamano
2022-07-19 0:09 ` [PATCH v2] docs: remove pre-v1.6.0 "repack --delta-base-offset" docs Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220719.86h73cvkbw.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).