From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] gc: add tests for --cruft and friends
Date: Thu, 04 Aug 2022 09:48:24 +0200 [thread overview]
Message-ID: <220804.86a68ke9d5.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <20220803205721.3686361-2-emilyshaffer@google.com>
On Wed, Aug 03 2022, Emily Shaffer wrote:
> In 5b92477f89 (builtin/gc.c: conditionally avoid pruning objects via
> loose, 2022-05-20) gc learned to respect '--cruft' and 'gc.cruftPacks'.
> '--cruft' is exercised in t5329-pack-objects-cruft.sh, but in a way that
> doesn't check whether a lone gc run generates these cruft packs.
> 'gc.cruftPacks' is never exercised.
>
> Add some tests to exercise these options to gc in the gc test suite.
>
> Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
> ---
> t/t6500-gc.sh | 36 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh
> index cd6c53360d..e4c2c3583d 100755
> --- a/t/t6500-gc.sh
> +++ b/t/t6500-gc.sh
> @@ -202,6 +202,42 @@ test_expect_success 'one of gc.reflogExpire{Unreachable,}=never does not skip "e
> grep -E "^trace: (built-in|exec|run_command): git reflog expire --" trace.out
> '
>
> +test_expect_success 'gc --cruft generates a cruft pack' '
> + git init crufts &&
> + test_when_finished "rm -fr crufts" &&
Let's "test_when_finished" first, then "git init", the point is to clean
up the directory if we fail.
> + (
> + cd crufts &&
> + test_commit base &&
> +
> + test_commit --no-tag foo &&
> + test_commit --no-tag bar &&
> + git reset HEAD^^ &&
> +
> + git gc --cruft &&
> +
> + cruft=$(basename $(ls .git/objects/pack/pack-*.mtimes) .mtimes) &&
> + test_path_is_file .git/objects/pack/$cruft.pack
> + )
> +'
...this...
> +test_expect_success 'gc.cruftPacks=true generates a cruft pack' '
> + git init crufts &&
> + test_when_finished "rm -fr crufts" &&
> + (
> + cd crufts &&
> + test_commit base &&
> +
> + test_commit --no-tag foo &&
> + test_commit --no-tag bar &&
> + git reset HEAD^^ &&
> +
> + git -c gc.cruftPacks=true gc &&
> +
> + cruft=$(basename $(ls .git/objects/pack/pack-*.mtimes) .mtimes) &&
> + test_path_is_file .git/objects/pack/$cruft.pack
> + )
> +'
> +
...whole thing seems to be copy/pasted aside from the git options.
If so let's factor this into a trivial helper that invokes git "$@",
then call it with "gc --cruft" and "-c ..."?
next prev parent reply other threads:[~2022-08-04 7:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 20:57 [PATCH 0/2] let feature.experimental imply gc.cruftPacks=true Emily Shaffer
2022-08-03 20:57 ` [PATCH 1/2] gc: add tests for --cruft and friends Emily Shaffer
2022-08-03 21:56 ` Junio C Hamano
2022-08-04 7:48 ` Ævar Arnfjörð Bjarmason [this message]
2022-08-04 16:09 ` Junio C Hamano
2022-08-03 20:57 ` [PATCH 2/2] config: let feature.experimental imply gc.cruftPacks=true Emily Shaffer
2022-08-03 22:05 ` Junio C Hamano
2022-08-04 13:05 ` Derrick Stolee
2022-08-04 16:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220804.86a68ke9d5.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).