From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: psmith@gnu.org
Cc: git@vger.kernel.org, Alexander Kanavin <alex.kanavin@gmail.com>
Subject: Re: [PATCH 1/1] Avoid multiple patterns when recipes generate one file
Date: Mon, 28 Nov 2022 19:57:56 +0100 [thread overview]
Message-ID: <221128.86k03ekis2.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <43914959458ef34a0f29271afa9c9d981c2b3553.camel@gnu.org>
On Mon, Nov 28 2022, Paul Smith wrote:
> On Mon, 2022-11-28 at 14:08 +0100, Ævar Arnfjörð Bjarmason wrote:
>> Whether we use eval/define or not (I just tried to avoid the
>> repetition) I think referring to $(DOC_MAN[157]) here probably makes
>> more sense if we're poking at these rules.
>>
>> I.e. in this case the rest of the Makefile is carrying forward what
>> manpages we're generating exactly, so rather than a wildcard %.1 to
>> %.xml we can narrow it down to just the %.1 files we're going to b
>> generating (but maybe that's best left for later...):
>
> I have no opinion on which is better :).
>
> I'm not sure what the above comment is asking for though: are you going
> to take over pushing this change? Or do you want me to reroll the
> commit with these changes instead? Or are we waiting for more
> opinions?
Just a suggestion in case you thought it helped, but I think we can just
go for your version.
next prev parent reply other threads:[~2022-11-28 18:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 22:42 [PATCH 0/1] Avoid multiple patterns when recipes generate one file Paul Smith
2022-11-27 22:42 ` [PATCH 1/1] " Paul Smith
2022-11-28 13:08 ` Ævar Arnfjörð Bjarmason
2022-11-28 18:33 ` Paul Smith
2022-11-28 18:57 ` Ævar Arnfjörð Bjarmason [this message]
2022-11-29 14:09 ` [PATCH v2 0/4] Makefiles: GNU make 4.4 fixes Ævar Arnfjörð Bjarmason
2022-11-29 14:09 ` [PATCH v2 1/4] Documentation/Makefile: de-duplicate *.[157] dependency list Ævar Arnfjörð Bjarmason
2022-11-30 4:17 ` Junio C Hamano
2022-11-29 14:09 ` [PATCH v2 2/4] Documentation/Makefile: avoid multiple patterns when generating one file Ævar Arnfjörð Bjarmason
2022-11-30 4:18 ` Junio C Hamano
2022-11-29 14:09 ` [PATCH v2 3/4] Makefiles: change search through $(MAKEFLAGS) for GNU make 4.4 Ævar Arnfjörð Bjarmason
2022-11-30 4:28 ` Junio C Hamano
2022-11-30 5:49 ` Paul Smith
2022-12-01 12:37 ` Ævar Arnfjörð Bjarmason
2022-11-29 14:09 ` [PATCH v2 4/4] Documentation/Makefile: narrow wildcard rules to our known files Ævar Arnfjörð Bjarmason
2022-11-30 1:27 ` [PATCH v2 0/4] Makefiles: GNU make 4.4 fixes Junio C Hamano
2022-11-30 8:23 ` [PATCH v3 0/1] " Ævar Arnfjörð Bjarmason
2022-11-30 8:23 ` [PATCH v3 1/1] Makefiles: change search through $(MAKEFLAGS) for GNU make 4.4 Ævar Arnfjörð Bjarmason
2022-11-30 16:29 ` Paul Smith
2022-11-30 22:23 ` Junio C Hamano
2022-12-06 7:48 ` Johannes Schindelin
2022-12-06 8:13 ` Ævar Arnfjörð Bjarmason
2022-12-06 9:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221128.86k03ekis2.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=alex.kanavin@gmail.com \
--cc=git@vger.kernel.org \
--cc=psmith@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).