From: Bagas Sanjaya <bagasdotme@gmail.com>
To: John Cai via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org
Cc: John Cai <johncai86@gmail.com>
Subject: Re: [PATCH 2/2] docs: add headers in MyFirstObjectWalk
Date: Sat, 30 Oct 2021 14:33:16 +0700 [thread overview]
Message-ID: <224a256e-8700-047d-bc12-834524a3c8f3@gmail.com> (raw)
In-Reply-To: <33cd9b2e8a675bf79132d312da8b7d8f4a2b84a3.1635343531.git.gitgitgadget@gmail.com>
On 27/10/21 21.05, John Cai via GitGitGadget wrote:
> From: John Cai <johncai86@gmail.com>
>
> In several places, headers need to be included or else the code won't
> compile. Since this is the first object walk, it would be nice to
> include them in the tutorial to make it easier to follow.
>
Patch title should be "#include missing headers" (dunno?)
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-10-30 7:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 14:05 [PATCH 0/2] fix up example code in MyFirstObjectWalk tutorial John Cai via GitGitGadget
2021-10-27 14:05 ` [PATCH 1/2] docs: fix places that break compliation in MyFirstObjectWalk John Cai via GitGitGadget
2021-10-27 17:05 ` Eric Sunshine
2021-10-27 14:05 ` [PATCH 2/2] docs: add headers " John Cai via GitGitGadget
2021-10-27 17:09 ` Eric Sunshine
2021-10-27 21:17 ` Junio C Hamano
2021-10-30 7:33 ` Bagas Sanjaya [this message]
2021-10-30 7:49 ` Eric Sunshine
2021-10-29 17:58 ` [PATCH v2 0/2] fix up example code in MyFirstObjectWalk tutorial John Cai via GitGitGadget
2021-10-29 17:58 ` [PATCH v2 1/2] docs: fix places that break compilation in MyFirstObjectWalk John Cai via GitGitGadget
2021-10-29 18:04 ` Eric Sunshine
2021-10-29 17:58 ` [PATCH v2 2/2] docs: add headers " John Cai via GitGitGadget
2021-10-29 19:52 ` [PATCH v3 0/2] fix up example code in MyFirstObjectWalk tutorial John Cai via GitGitGadget
2021-10-29 19:52 ` [PATCH v3 1/2] docs: fix places that break compilation in MyFirstObjectWalk John Cai via GitGitGadget
2021-10-29 19:52 ` [PATCH v3 2/2] docs: add headers " John Cai via GitGitGadget
2021-10-29 21:28 ` [PATCH v3 0/2] fix up example code in MyFirstObjectWalk tutorial Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224a256e-8700-047d-bc12-834524a3c8f3@gmail.com \
--to=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johncai86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).