From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] read-cache: use size_t for {base,df}_name_compare()
Date: Sun, 05 Feb 2023 22:09:18 +0100 [thread overview]
Message-ID: <230205.86y1pb7r9m.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <d272fd03-a005-f6ad-3f00-6b1a970a519f@web.de>
On Sun, Feb 05 2023, René Scharfe wrote:
> Support names of any length in base_name_compare() and df_name_compare()
> by using size_t for their length parameters. They pass the length on to
> memcmp(3), which also takes it as a size_t.
This looks good, and it's nice to see changes that slowly address the
greater topic of our outstanding -Werror=sign-compare issues.
prev parent reply other threads:[~2023-02-05 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 10:36 [PATCH] read-cache: use size_t for {base,df}_name_compare() René Scharfe
2023-02-05 21:09 ` Ævar Arnfjörð Bjarmason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230205.86y1pb7r9m.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).