git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jay Soffian <jaysoffian@gmail.com>
To: git@vger.kernel.org
Cc: "Jay Soffian" <jaysoffian@gmail.com>,
	"Matthieu Moy" <Matthieu.Moy@imag.fr>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Björn Steinbrink" <B.Steinbrink@gmx.de>,
	"Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Subject: [PATCH 3/4] send-email: correct two tests which were going interactive
Date: Tue, 31 Mar 2009 12:22:13 -0400	[thread overview]
Message-ID: <232681e20e15a61defb73a1645fd2c6b6aadd751.1238516122.git.jaysoffian@gmail.com> (raw)
In-Reply-To: <77c8a8123cb66821775b03fa0f3d2744de82b79b.1238516122.git.jaysoffian@gmail.com>
In-Reply-To: <cover.1238516122.git.jaysoffian@gmail.com>

Commit 67f1fe5 added two tests which went interactive under the
dash shell. This commit corrects the issue. Reported by
Björn Steinbrink <B.Steinbrink@gmx.de>

Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
 t/t9001-send-email.sh |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 195ff8b..84238f7 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -478,7 +478,8 @@ test_expect_success 'confirm detects EOF (inform assumes y)' '
 test_expect_success 'confirm detects EOF (auto causes failure)' '
 	CONFIRM=$(git config --get sendemail.confirm) &&
 	git config sendemail.confirm auto &&
-	GIT_SEND_EMAIL_NOTTY=1 \
+	GIT_SEND_EMAIL_NOTTY=1 &&
+	export GIT_SEND_EMAIL_NOTTY &&
 		test_must_fail git send-email \
 			--from="Example <nobody@example.com>" \
 			--to=nobody@example.com \
@@ -492,8 +493,9 @@ test_expect_success 'confirm detects EOF (auto causes failure)' '
 test_expect_success 'confirm doesnt loop forever' '
 	CONFIRM=$(git config --get sendemail.confirm) &&
 	git config sendemail.confirm auto &&
-	yes "bogus" | GIT_SEND_EMAIL_NOTTY=1 \
-		test_must_fail git send-email \
+	GIT_SEND_EMAIL_NOTTY=1 &&
+	export GIT_SEND_EMAIL_NOTTY &&
+		yes "bogus" | test_must_fail git send-email \
 			--from="Example <nobody@example.com>" \
 			--to=nobody@example.com \
 			--smtp-server="$(pwd)/fake.sendmail" \
-- 
1.6.2.1.427.g15408

  reply	other threads:[~2009-03-31 16:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-31 16:22 [PATCH 0/4] send-email: correct various issues Jay Soffian
2009-03-31 16:22 ` [PATCH 1/4] send-email: don't attempt to prompt if tty is closed Jay Soffian
2009-03-31 16:22   ` [PATCH 2/4] send-email: ask_default should apply to all emails, not just the first Jay Soffian
2009-03-31 16:22     ` Jay Soffian [this message]
2009-03-31 16:22       ` [PATCH 4/4] send-email: ensure quoted addresses are rfc2047 encoded Jay Soffian
2009-03-31 19:46       ` [PATCH 3/4] send-email: correct two tests which were going interactive Jeff King
2009-04-01  8:33 ` [PATCH 0/4] send-email: correct various issues Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=232681e20e15a61defb73a1645fd2c6b6aadd751.1238516122.git.jaysoffian@gmail.com \
    --to=jaysoffian@gmail.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=Matthieu.Moy@imag.fr \
    --cc=Uwe.Kleine-Koenig@digi.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).