From: "Mikael Magnusson" <mikachu@gmail.com>
To: "Avery Pennarun" <apenwarr@gmail.com>
Cc: "Eric Wong" <normalperson@yhbt.net>,
"Adam Roben" <aroben@apple.com>,
"Samuel Bronson" <naesten@gmail.com>,
B.Steinbrink@gmx.de, git@vger.kernel.org
Subject: Re: [PATCH] Revert "git-svn: Speed up fetch"
Date: Sun, 29 Jun 2008 01:51:09 +0200 [thread overview]
Message-ID: <237967ef0806281651p3abf6ae4j9169cdc5bbf8f85d@mail.gmail.com> (raw)
In-Reply-To: <1214686673-28099-1-git-send-email-apenwarr@gmail.com>
2008/6/28 Avery Pennarun <apenwarr@gmail.com>:
> This reverts commit ffe256f9bac8a40ff751a9341a5869d98f72c285, because it
> was causing errors of the form:
>
> Checksum mismatch: trunk/.depend 16e748c219f9f95bf3d05c6b2af5444290bc8471
> expected: 05fb5edb8c8057be006c7e913ae0c764
> got: 763b9a426c5bd61e0a85252459d37cfa
>
> Note that the exact failing file and checksum seems to vary if you clear
> the repository and try again.
>
> Conflicts:
>
> git-svn.perl
Wasn't this the problem that was fixed by
d683a0e00cd4734b4fab704baef1ee76205722be[1]?
--
Mikael Magnusson
[1]
commit d683a0e00cd4734b4fab704baef1ee76205722be
Author: Junio C Hamano <gitster@pobox.com>
Date: Tue May 27 23:33:22 2008 -0700
Git::cat_blob: allow using an empty blob to fix git-svn breakage
Recent "git-svn optimization" series introduced Git::cat_blob() subroutine
whose interface was broken in that it returned the size of the blob but
signalled an error by returning 0. You can never use an empty blob with
such an interface.
This fixes the interface to return a negative value to signal an error.
Reported by Björn Steinbrink.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
next prev parent reply other threads:[~2008-06-28 23:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 19:48 git-svn messed up import, badly Björn Steinbrink
2008-06-28 20:57 ` [PATCH] Revert "git-svn: Speed up fetch" Avery Pennarun
2008-06-28 23:33 ` [PATCH v2] git-svn: avoid filling up the disk with temp files Avery Pennarun
2008-06-29 0:58 ` Björn Steinbrink
2008-06-29 1:21 ` [PATCH] git cat-file: Fix memory leak in batch mode Björn Steinbrink
2008-06-29 3:36 ` Junio C Hamano
2008-06-29 11:54 ` Björn Steinbrink
2008-06-29 2:24 ` [PATCH v2] git-svn: avoid filling up the disk with temp files Björn Steinbrink
2008-06-29 2:38 ` Eric Wong
2008-06-28 23:51 ` Mikael Magnusson [this message]
2008-06-28 23:58 ` [PATCH] Revert "git-svn: Speed up fetch" Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237967ef0806281651p3abf6ae4j9169cdc5bbf8f85d@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=B.Steinbrink@gmx.de \
--cc=apenwarr@gmail.com \
--cc=aroben@apple.com \
--cc=git@vger.kernel.org \
--cc=naesten@gmail.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).