git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mikael Magnusson" <mikachu@gmail.com>
To: "Scott Moser" <smoser@brickies.net>
Cc: "Josef Jeff Sipek" <jsipek@cs.sunysb.edu>, git@vger.kernel.org
Subject: Re: [PATCH] explicitly set LANG to 'C' in for guilt run-tests
Date: Mon, 29 Sep 2008 22:25:48 +0200	[thread overview]
Message-ID: <237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com> (raw)
In-Reply-To: <1222714272-9557-1-git-send-email-smoser@brickies.net>

2008/9/29 Scott Moser <smoser@brickies.net>:
> The output of guilt's run-tests is dependent on LANG due to reliance on a
> given sorting algorithm. Currently, the test '052' will fail if LANG is
> set to 'en_US.UTF-8' (and likely others values).
>
> Remove the assumption by explicitly setting this in run-tests.
>
> Signed-off-by: Scott Moser <smoser@brickies.net>
> ---
>  regression/run-tests |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/regression/run-tests b/regression/run-tests
> index 8f572eb..945150b 100755
> --- a/regression/run-tests
> +++ b/regression/run-tests
> @@ -2,6 +2,7 @@
>
>  export REG_DIR="$PWD"
>  export PATH="$PWD/bin:$PATH"
> +export LANG=C
>
>  source scaffold
>
> --
> 1.5.6.3

If I'm not mistaken, $LANG is used as the ultimate fallback, while LC_ALL is
the one that overrides all others, so you probably want to set LC_ALL. I'm
unsure which off the specific ones would apply here, but very likely it's
LC_COLLATE. In other words, if LC_ALL is set, it is used, otherwise if
LC_COLLATE is set it is used, otherwise if LANG is set, it is used,
otherwise, "POSIX" is used.

-- 
Mikael Magnusson

  reply	other threads:[~2008-09-29 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-29 18:51 [PATCH] explicitly set LANG to 'C' in for guilt run-tests Scott Moser
2008-09-29 20:25 ` Mikael Magnusson [this message]
2008-09-29 20:49   ` Josef Jeff Sipek
2008-09-29 21:01     ` Scott Moser
2008-09-30  4:42   ` Josef 'Jeff' Sipek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237967ef0809291325p7a0e3581vac348a1e99dbd4ed@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jsipek@cs.sunysb.edu \
    --cc=smoser@brickies.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).