git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Document that git-log takes --all-match.
       [not found] <237967ef0811021028w3aa22411t99b2203a9148bbf6@mail.gmail.com>
@ 2008-11-02 18:32 ` Mikael Magnusson
  2008-11-03  6:17   ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Mikael Magnusson @ 2008-11-02 18:32 UTC (permalink / raw)
  To: Git Mailing List, Junio C Hamano

Signed-off-by: Mikael Magnusson <mikachu@gmail.com>

---

It's already listed in the bash completion. Feel free to reword.
Looking at this I can't help but feel that the text for
--grep/--author/--committer is misleading, since they say they will
limit to commits blabla, but they don't if another is given. Ie they
only do what they say if you give the --all-match option.

 Documentation/rev-list-options.txt |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

index 0ce916a..966276b 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -174,6 +174,10 @@ endif::git-rev-list[]
       Limit the commits output to ones with log message that
       matches the specified pattern (regular expression).

+--all-match::
+       Limit the commits output to ones that match all given --grep,
+       --author and --committer instead of ones that match at least one.
+
 -i::
 --regexp-ignore-case::

--
1.6.0.2.GIT

--
Mikael Magnusson

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Document that git-log takes --all-match.
  2008-11-02 18:32 ` [PATCH] Document that git-log takes --all-match Mikael Magnusson
@ 2008-11-03  6:17   ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-11-03  6:17 UTC (permalink / raw)
  To: Mikael Magnusson; +Cc: Git Mailing List

"Mikael Magnusson" <mikachu@gmail.com> writes:

> It's already listed in the bash completion. Feel free to reword.

This is a bad strategy to get your patch accepted except on a rare
occasion when I'm not too lazy nor busy to "feel free".  Besides, the
patch is whitespace damaged.

I fixed it up and queued it nevertheless.  Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-03  6:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <237967ef0811021028w3aa22411t99b2203a9148bbf6@mail.gmail.com>
2008-11-02 18:32 ` [PATCH] Document that git-log takes --all-match Mikael Magnusson
2008-11-03  6:17   ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).