git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikael Magnusson <mikachu@gmail.com>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: git@vger.kernel.org
Subject: [PATCH] Make tig call the correct git config command
Date: Sun, 8 Feb 2009 08:46:55 +0100	[thread overview]
Message-ID: <237967ef0902072346x4537f70dua37ba897fac99361@mail.gmail.com> (raw)

2009/2/7 Mikael Magnusson <mikachu@gmail.com>:
> 2009/2/5 Jonas Fonseca <fonseca@diku.dk>:
>> Hello,
>>
>> Here is a much needed update fixing multiple regressions from the
>> introduction of the IO API in 0.13. Among improvements is the much
>> requested ability to restore the position in the stage view when staging
>> diff hunks. Also noteworthy is the many optimizations of the screen
>> updating to make it work better across slow links. Finally, beware that
>> a handful of incompatibilities can cause problems.
>
> I'm having a problem with tig taking 2 seconds to start up, which
> seems to be related to the 'typo checking' feature of git. After
> figuring out how to stop strace from helpfully saying
> write(2, "WARNING: You called a Git program"..., 137) = 137
> I got this (with -s 100):
> [pid 29708] write(2, "WARNING: You called a Git program named 'git
> config', which does not exist.\nContinuing under the assu"..., 137) =
> 137
> [pid 29708] write(2, "in 2.0 seconds automatically...\n"..., 32) = 32
>
> The output however also contains lots of git config strings, which is
> confusing. Is tig running git config twice and failing one of the
> times? (Running git config from the cmdline works fine).

Turns out it was as simple as this:

diff --git a/configure.ac b/configure.ac
index b179389..bdea8de 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config
 GIT_CONFIG="repo-config"
 git config --list >/dev/null && GIT_CONFIG="config"
 AC_MSG_RESULT([$GIT_CONFIG])
-AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[git config subcommand])
+AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[config subcommand])

 AC_CHECK_PROGS(ASCIIDOC, [asciidoc false])
 AC_CHECK_PROGS(XMLTO, [xmlto false])

-- 
Mikael Magnusson

             reply	other threads:[~2009-02-08  7:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-08  7:46 Mikael Magnusson [this message]
2009-02-08  7:49 ` [PATCH] Make tig call the correct git config command Mikael Magnusson
2009-02-08  9:56   ` Jonas Fonseca
2009-02-18 11:12     ` Kris Shannon
2009-02-18 11:29       ` Jonas Fonseca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=237967ef0902072346x4537f70dua37ba897fac99361@mail.gmail.com \
    --to=mikachu@gmail.com \
    --cc=fonseca@diku.dk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).