Re: [PATCH] Make tig call the correct git config command

[Mikael Magnusson <mikachu@gmail.com>]

As it turns out I'm an idiot, that's just the configure help message.
Rerunning autoconf + configure in fact generates a completely correct
commandline. Sorry about the noise.

2009/2/8 Mikael Magnusson <mikachu@gmail.com>:
> 2009/2/7 Mikael Magnusson <mikachu@gmail.com>:
>> 2009/2/5 Jonas Fonseca <fonseca@diku.dk>:
>>> Hello,
>>>
>>> Here is a much needed update fixing multiple regressions from the
>>> introduction of the IO API in 0.13. Among improvements is the much
>>> requested ability to restore the position in the stage view when staging
>>> diff hunks. Also noteworthy is the many optimizations of the screen
>>> updating to make it work better across slow links. Finally, beware that
>>> a handful of incompatibilities can cause problems.
>>
>> I'm having a problem with tig taking 2 seconds to start up, which
>> seems to be related to the 'typo checking' feature of git. After
>> figuring out how to stop strace from helpfully saying
>> write(2, "WARNING: You called a Git program"..., 137) = 137
>> I got this (with -s 100):
>> [pid 29708] write(2, "WARNING: You called a Git program named 'git
>> config', which does not exist.\nContinuing under the assu"..., 137) =
>> 137
>> [pid 29708] write(2, "in 2.0 seconds automatically...\n"..., 32) = 32
>>
>> The output however also contains lots of git config strings, which is
>> confusing. Is tig running git config twice and failing one of the
>> times? (Running git config from the cmdline works fine).
>
> Turns out it was as simple as this:
>
> diff --git a/configure.ac b/configure.ac
> index b179389..bdea8de 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -28,7 +28,7 @@ AC_MSG_CHECKING([which config
>  GIT_CONFIG="repo-config"
>  git config --list >/dev/null && GIT_CONFIG="config"
>  AC_MSG_RESULT([$GIT_CONFIG])
> -AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[git config subcommand])
> +AC_DEFINE_UNQUOTED(GIT_CONFIG,"$GIT_CONFIG",[config subcommand])
>
>  AC_CHECK_PROGS(ASCIIDOC, [asciidoc false])
>  AC_CHECK_PROGS(XMLTO, [xmlto false])
>
> --
> Mikael Magnusson
>



-- 
Mikael Magnusson