git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ydirson@free.fr
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Yann Dirson <dirson@bertin.fr>
Subject: Re: Commit notes workflow
Date: Wed, 15 Jun 2011 11:20:13 +0200 (CEST)	[thread overview]
Message-ID: <243233943.1008861308129613120.JavaMail.root@zimbra44-e7.priv.proxad.net> (raw)
In-Reply-To: <201106141215.50689.johan@herland.net>

> > A (minor) problem with the second possibility is that this naming
> > convention could evolve, eg. if we end up with something like was
> > proposed in [1] for 1.8.0.  Is there any real drawback with the
> first
> > suggestion ?
> > 
> > [1] http://marc.info/?l=git&m=129661334011986&w=4
> 
> My gut feeling is to keep some sort of limit notes refs, and if/when we get 
> around to implementing my proposal in [1] (or some variation thereof), we 
> will of course extend the limit to put "refs/remotes/$remote/notes/*" (or 
> whatever is decided) in the same category as "refs/notes/*".
> 
> In the meantime, I'm unsure if it's a good idea to remove the limitation 
> altogether (allowing notes refs everywhere), since re-introducing a limit at 
> a later point will then be MUCH harder...

I'm still unsure what that limitation brings to us.  OTOH, it has at least one
funny downside: when someone tries to refer to some forbidden ref using --ref, it
gets silently requalified:

$ git notes --ref=refs/remote-notes/foo add
$ find .git/refs/notes/ -type f
.git/refs/notes/refs/remote-notes/foo
$

It just seems so wrong...  Surely we can mitigate it by considering a ref starting
with "refs/" to be absolute, and thus never prepend "refs/notes/" to it, but it rather
sounds to me a symptom that we may not want to filter things anyway.

  parent reply	other threads:[~2011-06-15  9:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13  7:09 Commit notes workflow Yann Dirson
2011-06-14 10:15 ` Johan Herland
     [not found]   ` <f81891b81d39.4df76a5c@bertin.fr>
2011-06-14 14:41     ` Johan Herland
2011-06-15  9:20   ` ydirson [this message]
2011-06-15  9:37     ` Johan Herland
2011-06-15  9:57     ` ydirson
2011-06-15 10:53       ` Johan Herland
2011-06-18 21:06         ` [PATCH 0/6] Small notes usability improvements Yann Dirson
2011-06-18 21:06           ` [PATCH 1/6] Bring notes.c template handling in line with commit.c Yann Dirson
2011-06-19 21:23             ` Johan Herland
2011-06-19 22:50               ` Junio C Hamano
2011-06-20  7:41                 ` Johan Herland
2011-06-20 18:48                   ` Yann Dirson
2011-06-21 19:39                     ` Yann Dirson
2011-06-18 21:06           ` [PATCH 2/6] Factorize shortening of notes refname for display Yann Dirson
2011-06-19 21:25             ` Johan Herland
2011-06-19 22:51               ` Junio C Hamano
2011-06-20 18:49                 ` Yann Dirson
2011-06-18 21:06           ` [PATCH 3/6] Include name of notes ref in template when creating/editing notes Yann Dirson
2011-06-18 21:06           ` [PATCH 4/6] Allow "git notes merge" to use refs/remote-notes/ as a source Yann Dirson
2011-06-19 21:45             ` Johan Herland
2011-06-18 21:06           ` [PATCH 5/6] Assume a note ref starting with refs must not be prepended refs/notes/ Yann Dirson
2011-06-18 21:06           ` [PATCH 6/6] RFC - Notes merge: die when asked to merge a non-existent ref Yann Dirson
2011-06-19 22:03             ` Johan Herland
2011-06-20  7:16               ` Jeff King
2011-06-20  7:29                 ` Johan Herland
2011-06-19 22:06           ` [PATCH 0/6] Small notes usability improvements Johan Herland
  -- strict thread matches above, loose matches on Subject: below --
2011-06-14 14:21 Commit notes workflow ydirson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=243233943.1008861308129613120.JavaMail.root@zimbra44-e7.priv.proxad.net \
    --to=ydirson@free.fr \
    --cc=dirson@bertin.fr \
    --cc=git@vger.kernel.org \
    --cc=johan@herland.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).