From: Illia Bobyr <illia.bobyr@gmail.com>
To: git@vger.kernel.org
Subject: Long names for `git log -S` and `git log -G`
Date: Mon, 18 Nov 2024 15:56:30 -0800 [thread overview]
Message-ID: <24458598-ebbe-41fc-8517-457fa65ed481@gmail.com> (raw)
Hello,
I would like to add long names for the `-S` and `-G` options for `git log`.
It seems that most options have long versions, though there are some
exceptions.
I was wondering if there could be any objections.
And also, what would be a good name for each.
Both are provided by the diff-pickaxe functionality.
`-S` is already affected by `--pickaxe-regex` and both `-G` and `-S` are
affected by `--pickaxe-all`.
Also,`diffcore` docs says:
> "-G<regular-expression>" (mnemonic: grep)
I was thinking of `--pickaxe` for `-S` and `--grep` for `-G`.
And it would probably make sense to discuss this before I try submitting
a patch.
`--pickaxe-grep` for `-G` seems like a reasonable alternative name for `-G`.
Not sure what would be a reasonably short alternative for `-S`.
`--pickaxe-occurance-change` seems too long, and might not be as clear.
`--pickaxe-occurance-count-change` is just way too long.
Thank you,
Illia Bobyr
next reply other threads:[~2024-11-18 23:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 23:56 Illia Bobyr [this message]
2024-11-19 3:52 ` Long names for `git log -S` and `git log -G` Junio C Hamano
2024-11-19 18:58 ` Jeff King
2024-11-21 23:31 ` Illia Bobyr
2024-11-22 10:51 ` Junio C Hamano
2025-02-05 2:24 ` [PATCH v2 0/1] " Illia Bobyr
2025-02-05 2:24 ` [PATCH v2 1/1] diff: --patch{-modifies,grep} arg names for -S and -G Illia Bobyr
2025-02-05 7:15 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24458598-ebbe-41fc-8517-457fa65ed481@gmail.com \
--to=illia.bobyr@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).