From: Kristoffer Haugsbakk <code@khaugsbakk.name>
To: gitster@pobox.com
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: [PATCH v2 1/1] config: add back code comment
Date: Mon, 29 Jan 2024 18:57:51 +0100 [thread overview]
Message-ID: <24f536d575d508b0784e0adf647cb2334f6704d8.1706550761.git.code@khaugsbakk.name> (raw)
In-Reply-To: <cover.1706550761.git.code@khaugsbakk.name>
c15129b699 (config: factor out global config file retrieval, 2024-01-18)
was a refactor that moved some of the code in this function to
`config.c`. However, in the process I managed to drop this code comment
which explains `$HOME not set`.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
Acked-by: Patrick Steinhardt <ps@pks.im>
---
builtin/config.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/builtin/config.c b/builtin/config.c
index 08fe36d499..b55bfae7d6 100644
--- a/builtin/config.c
+++ b/builtin/config.c
@@ -710,6 +710,12 @@ int cmd_config(int argc, const char **argv, const char *prefix)
if (use_global_config) {
given_config_source.file = git_global_config();
if (!given_config_source.file)
+ /*
+ * It is unknown if HOME/.gitconfig exists, so
+ * we do not know if we should write to XDG
+ * location; error out even if XDG_CONFIG_HOME
+ * is set and points at a sane location.
+ */
die(_("$HOME not set"));
given_config_source.scope = CONFIG_SCOPE_GLOBAL;
} else if (use_system_config) {
--
2.43.0
prev parent reply other threads:[~2024-01-29 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 18:31 [PATCH 0/1] config: add back code comment Kristoffer Haugsbakk
2024-01-28 18:31 ` [PATCH 1/1] " Kristoffer Haugsbakk
2024-01-29 11:32 ` Patrick Steinhardt
2024-01-29 18:28 ` Junio C Hamano
2024-01-29 17:57 ` [PATCH v2 0/1] " Kristoffer Haugsbakk
2024-01-29 17:57 ` Kristoffer Haugsbakk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f536d575d508b0784e0adf647cb2334f6704d8.1706550761.git.code@khaugsbakk.name \
--to=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).