From: Jake Goulding <goulding@vivisimo.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Add --contains flag to git tag
Date: Tue, 20 Jan 2009 22:54:36 -0500 (EST) [thread overview]
Message-ID: <25058429.247441232510076471.JavaMail.root@scalix.vivisimo.com> (raw)
In-Reply-To: <20090121032058.GG21473@genesis.frugalware.org>
That is actually in a subsequent commit (in my unmarked patch sequence).
I actually have 1 commit for the code change, one for documentation, and one for the test case. Should I squash all these together?
Also, my test case is in a separate file (t7704-tag-contains.sh) as that is how I read t/README. Was this incorrect?
Thanks!
-Jake
----- Original Message -----
From: "Miklos Vajna" <vmiklos@frugalware.org>
To: "Jake Goulding" <goulding@vivisimo.com>
Cc: git@vger.kernel.org
Sent: Tuesday, January 20, 2009 10:20:58 PM GMT -05:00 US/Canada Eastern
Subject: Re: [PATCH] Add --contains flag to git tag
On Tue, Jan 20, 2009 at 08:37:09PM -0500, Jake Goulding <goulding@vivisimo.com> wrote:
> Please let me know what else I have inevitably messed up, and I shall
> endeavor to fix and resubmit.
Please document your improvements in Documentation/git-tag.txt and don't
forget to add a testcase to t7004-tag.sh.
next prev parent reply other threads:[~2009-01-21 3:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1232501631-21531-3-git-send-email-goulding@vivisimo.com>
2009-01-21 1:37 ` [PATCH] Add --contains flag to git tag Jake Goulding
2009-01-21 3:20 ` Miklos Vajna
2009-01-21 3:54 ` Jake Goulding [this message]
2009-01-21 8:21 ` Johannes Schindelin
2009-01-22 17:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25058429.247441232510076471.JavaMail.root@scalix.vivisimo.com \
--to=goulding@vivisimo.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).