git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Krefting <peter@softwolves.pp.se>
To: "Osipov, Michael (IN IT IN)" <michael.osipov@innomotics.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: bisect does not respect 'log.date'
Date: Mon, 25 Mar 2024 21:27:30 +0100 (CET)	[thread overview]
Message-ID: <25d716fa-bd32-4ff0-20f2-05ff51750911@softwolves.pp.se> (raw)
In-Reply-To: <4e2b22fb-7496-4f67-a89f-9fcbffc73a1a@siemens.com>

Osipov, Michael (IN IT IN):

> Interesting thought, but that also means that "git show" misbehaves because 
> it respects "log.date" and there is no "show.date". I still think that 
> consistency shouldn't be obeyed.
> I'd be happy if someone could consider this improvement.

I've also been annoyed at this. Everything else respects the date 
setting.

Bisect displays the commit through an invocation of "git diff-tree 
--pretty". This command does not respect the log.date setting, but it 
can be passed the --date parameter to format the date.

The question is what is the correct way of fixing this; is it to make 
"git diff-tree --pretty" respect the "log.date" option, or to make 
"git bisect" pass a --date pate parameter to the invocation of it?

Or perhaps everything should just be made support the "TIME_STYLE" that 
GNU tools use? GNU ls is so much nicer to use with "TIME_STYLE=long-iso" 
set.

-- 
\\// Peter - http://www.softwolves.pp.se/

  reply	other threads:[~2024-03-25 21:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 11:07 bisect does not respect 'log.date' Osipov, Michael (IN IT IN)
2024-03-13 18:24 ` Junio C Hamano
2024-03-13 19:26   ` Osipov, Michael (IN IT IN)
2024-03-25 20:27     ` Peter Krefting [this message]
2024-03-25 21:49       ` Junio C Hamano
2024-03-28 20:53         ` [RFC PATCH] bisect: Honor log.date Peter Krefting
2024-03-28 21:38           ` Eric Sunshine
2024-03-28 23:18             ` Peter Krefting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25d716fa-bd32-4ff0-20f2-05ff51750911@softwolves.pp.se \
    --to=peter@softwolves.pp.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=michael.osipov@innomotics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).