From: Jason Riedy <ejr@EECS.Berkeley.EDU>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Spell __attribute__ correctly in cache.h.
Date: Tue, 23 Aug 2005 14:20:58 -0700 [thread overview]
Message-ID: <2655.1124832058@lotus.CS.Berkeley.EDU> (raw)
In-Reply-To: <7v64u1ya7c.fsf@assigned-by-dhcp.cox.net>
And Junio C Hamano writes:
- > BTW, how would people feel about replacing the
- > setenv() and unsetenv() calls with the older putenv()?
- No comment on this one at this moment until I do my own digging
- a bit.
If you're interested, I have a few patches in
http://www.cs.berkeley.edu/~ejr/gits/git.git#portable
that let git compile with xlc on AIX and Sun's non-c99
cc on Solaris. Changes:
+ Replace C99 array initializers with code.
+ Replace unsetenv() and setenv() with older putenv().
+ Include sys/time.h in daemon.c.
+ Fix ?: statements.
+ Replace zero-length array decls with [].
The top two may or may not be acceptable. The third may
not be necessary if I can find the right -Ds for fd_set.
The last two just remove GNU C extensions. Makefile
changes (including extra -Ds for features) not included,
but could be. Tell me if you want any of these mailed.
Not all the tests pass on non-Linux, but I won't have time
to look at them for a bit. With the GNU findutils and
coreutils, it works well enough for basic use. The failing
tests might be from using non-GNU utilities. Rooting out
all the dependencies is a tad painful.
Jason
next prev parent reply other threads:[~2005-08-23 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-19 4:10 [PATCH] Spell __attribute__ correctly in cache.h Jason Riedy
2005-08-19 9:04 ` Junio C Hamano
2005-08-19 14:58 ` Jason Riedy
2005-08-19 19:53 ` Junio C Hamano
2005-08-23 21:20 ` Jason Riedy [this message]
2005-08-28 10:14 ` Junio C Hamano
2005-08-28 17:11 ` Jason Riedy
2005-08-28 17:46 ` Linus Torvalds
2005-08-28 19:08 ` Antti-Juhani Kaijanaho
2005-08-28 19:48 ` Linus Torvalds
2005-08-29 8:17 ` Martijn Kuipers
2005-08-29 8:35 ` Antti-Juhani Kaijanaho
2005-08-29 8:55 ` Martijn Kuipers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2655.1124832058@lotus.CS.Berkeley.EDU \
--to=ejr@eecs.berkeley.edu \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).