From: Eric Raible <raible@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
Daniel Barkalow <barkalow@iabervon.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Schrödinger's diff
Date: Tue, 7 Jul 2009 23:13:01 -0700 [thread overview]
Message-ID: <279b37b20907072313t79ddded2k84c819887c234e8b@mail.gmail.com> (raw)
In-Reply-To: <7v8wizanqr.fsf@alter.siamese.dyndns.org>
On Tue, Jul 7, 2009 at 7:54 PM, Junio C Hamano<gitster@pobox.com> wrote:
> Eric Raible <raible@gmail.com> writes:
>
>> So what's the best way of "fixing once and for all" a repo infected with
>> carriage returns when you want to use autocrlf=true moving forward?
>
> Didn't "rm -f .git/index && git reset --hard HEAD" work?
Will, it "worked" in the sense that it usually [1] allows
"git diff --name-only" to correctly show the files that were
checked in with crlf endings and core.autocrlf false.
Those files are then out-of-date when core.autocrlf is
true and .git/index is up-to-date.
In other words, that first step worked around the fact
that sometimes that .git/index was out of date.
By "fixing it once and for all" I was trying to refer to creating
the correct commit to abolish the carriage returns from my repo.
I ended up with this crude-but-obvious loop which
generates many LF->CRLF warnings [2]:
for i in `git diff --name-only`; do
echo $i
sed 's/0x0D//' < $i > foo
mv foo $i
git add $i
done
>> Would you accept a patch explaining how "git reset --hard" doesn't
>> actually rebuild the index from scratch,...
>
> Absolutely.
I'll try to get to it, given the $dayjob / $significant_other constraints.
- Eric
[1] I've had cases where for whatever reasons a "git read-tree HEAD"
seemed to be required, but I don't have the recipe yet.
[2] Which can be abolished by wrapping it in autocrlf=false
before and autocrlf=true after
next prev parent reply other threads:[~2009-07-08 6:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 6:53 Schrödinger's diff Eric Raible
2009-07-07 7:28 ` Johannes Sixt
2009-07-07 7:52 ` Andreas Ericsson
2009-07-07 17:36 ` Daniel Barkalow
2009-07-07 19:36 ` Jeff King
2009-07-07 19:48 ` Junio C Hamano
2009-07-07 19:54 ` Jeff King
2009-07-07 22:22 ` Junio C Hamano
2009-07-08 0:17 ` Eric Raible
2009-07-08 2:54 ` Junio C Hamano
2009-07-08 6:13 ` Eric Raible [this message]
2009-07-07 20:30 ` Eric Raible
2009-07-07 20:48 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279b37b20907072313t79ddded2k84c819887c234e8b@mail.gmail.com \
--to=raible@gmail.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).