public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Tian Yuchen <cat@malon.dev>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1] replay.c: support replaying root commits
Date: Sat, 28 Mar 2026 11:24:57 +0800	[thread overview]
Message-ID: <283d016a1f109129e462b547e604a724@purelymail.com> (raw)
In-Reply-To: <xmqqcy0pje5c.fsf@gitster.g>

Hi Junio,

> Junio C Hamano <gitster@pobox.com> writes:
> 
>> Tian Yuchen <cat@malon.dev> writes:
>> 
>>> 'git replay' does not support replaying root commits, as indicated by
>>> the FIXME comment. If a user attempts to replay a root commit, the 
>>> 'die()'
>>> in 'replay_revisions()' will be called.
>> 
>> Please be aware of your surroundings.  I think there are multiple
>> topics that work on this file and among them there is a topic to
>> address the same issue, if I am not mistaken.
>> 
>> The list archive is your friend, for example, you can try these:
>> 
>>     https://lore.kernel.org/git/?q=replay+root
>>     https://lore.kernel.org/git/?q=dfn%3Areplay.c+%22root+commit%22
>> 
>> Thanks.
> 
> Oops, sent without completing what I needed to say.
> 
> After you find out that other people are working in the vicinity,
> some of them even may be working on the same itch you had, instead
> of silently letting them continue, join the conversation and help
> them polish their work.  You can give reviews, you can supply test
> cases, you can polish their documentation, etc.
> 
> Let's make this a team effort, not authors completing against each
> other, or authors working on their own thing without paying any
> attention to what others are doing.
> 
> Thanks.

Oops, looks like I missed a few threads. Before I started, I actually
searched the mailing list to see if anyone else was working on this,
maybe I used the wrong keywords.

Thanks for pointing out. I'll join the discussion. ;)

Regards, Yuchen

      reply	other threads:[~2026-03-28  3:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 18:09 [PATCH v1] replay.c: support replaying root commits Tian Yuchen
2026-03-27 18:28 ` Junio C Hamano
2026-03-27 18:55   ` Junio C Hamano
2026-03-28  3:24     ` Tian Yuchen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=283d016a1f109129e462b547e604a724@purelymail.com \
    --to=cat@malon.dev \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox