From: "Philip Oakley" <philipoakley@iee.org>
To: "Git List" <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Barry Wardell" <barry.wardell@gmail.com>,
"\"Joachim Schmitz\"" <jojo@schmitz-digital.de>
Subject: Re: [PATCH v3 0/2] Make git-svn work with gitdir links
Date: Mon, 21 Jan 2013 21:45:53 -0000 [thread overview]
Message-ID: <2931F4CC43E4406DBB878482C2F0E4F4@PhilipOakley> (raw)
In-Reply-To: kdjip9$4j7$1@ger.gmane.org
From: "Joachim Schmitz" <jojo@schmitz-digital.de>
Sent: Monday, January 21, 2013 2:19 PM
> Junio C Hamano wrote:
>> Barry Wardell <barry.wardell@gmail.com> writes:
[...]
>> Thanks for your persistence ;-) As this is a pretty old topic, I'll
>> give two URLs for people who are interested to view the previous
>> threads:
>>
>> http://thread.gmane.org/gmane.comp.version-control.git/192133
>> http://thread.gmane.org/gmane.comp.version-control.git/192127
>>
>> You would want to mark it as test_expect_failure in the first patch
>> and then flip it to text_expect_success in the second patch where
>> you fix the breakage? Otherwise, after applying the first patch,
>> the testsuite will break needlessly.
>
> I'd just apply them the other way round, 1st fix the problem, 2nd add
> a test for it
Isn't it a case of, 1st demonstrate the problem with a test, and then
2nd fix the problem.
Those less principled could could simply "fix" a non-existent problem
merely to get themselves into the change log, or worse, even if one may
fix-test under the hood.
>
> Bye, Jojo
Philip
next prev parent reply other threads:[~2013-01-21 21:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 19:53 [PATCH v2] git-svn: Simplify calculation of GIT_DIR Barry Wardell
2012-03-08 0:51 ` Eric Wong
2013-01-21 1:22 ` [PATCH v3 0/2] Make git-svn work with gitdir links Barry Wardell
2013-01-21 1:22 ` [PATCH 1/2] git-svn: Add test for git-svn repositories with a gitdir link Barry Wardell
2013-01-21 1:22 ` [PATCH 2/2] git-svn: Simplify calculation of GIT_DIR Barry Wardell
2013-01-21 1:50 ` [PATCH v3 0/2] Make git-svn work with gitdir links Junio C Hamano
2013-01-21 14:19 ` Joachim Schmitz
2013-01-21 21:45 ` Philip Oakley [this message]
2013-01-21 22:08 ` Junio C Hamano
2013-01-23 2:32 ` Eric Wong
2013-01-23 2:53 ` Junio C Hamano
2013-01-23 12:08 ` Barry Wardell
[not found] ` <CAHrK+Z-uXAEgd_HuisbioO8=D7DEdmceeUEz3A1Jr_rtm7a3WA@mail.gmail.com>
2013-01-24 1:27 ` Eric Wong
2013-01-24 5:29 ` Junio C Hamano
2013-01-24 10:14 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2931F4CC43E4406DBB878482C2F0E4F4@PhilipOakley \
--to=philipoakley@iee.org \
--cc=barry.wardell@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jojo@schmitz-digital.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox