Git development
 help / color / mirror / Atom feed
From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>
Cc: "GitList" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 1/2] Doc rebase: Describe rebase as excluding merge commits
Date: Mon, 20 May 2013 22:55:21 +0100	[thread overview]
Message-ID: <2F59222ECBA14673815BF42E6A7CE5A5@PhilipOakley> (raw)
In-Reply-To: 7v1u92xnuw.fsf@alter.siamese.dyndns.org

From: "Junio C Hamano" <gitster@pobox.com>
Sent: Monday, May 20, 2013 5:43 AM
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Philip Oakley wrote:
>>
>>> Describe rebase in the description section.
>>
>> It already does that. :)  I think you mean "start with a summary",
>> which is a valuable improvement.
>
> It indeed is a good idea to give the "high-level introduction" at
> the very beginning, but I do not think it should describe only one
> of the three major modes of "git rebase" (i.e. no -m, no -i), like
> the proposed patch text does.  We should instead say what it is used
> for and why the user would want to use it that is common across
> these modes at a very high level.

That would repeat the NAME issue (of trying too hard to be exact & 
precise). This introductory text is that "summary". The patch 2/2 should 
be the one for the extra detail of the various whys and wherefores - at 
least that was my intent.

>
>> DESCRIPTION
>> -----------
>> <brief description of the purpose of the command, including some 
>> token
>> mention of *why* a user would want to use it (e.g., "so that the 
>> patches
>> apply cleanly to their new base").>
>
> Exactly.
> --

  reply	other threads:[~2013-05-20 21:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-19 11:52 [RFC/PATCH 0/2] Improve rebase documenation Philip Oakley
2013-05-19 11:52 ` [RFC/PATCH 1/2] Doc rebase: Describe rebase as excluding merge commits Philip Oakley
2013-05-19 18:08   ` Jonathan Nieder
2013-05-19 22:41     ` Philip Oakley
2013-05-20  4:43     ` Junio C Hamano
2013-05-20 21:55       ` Philip Oakley [this message]
2013-05-20 22:29         ` Junio C Hamano
2013-05-19 11:52 ` [RFC/PATCH 2/2] Doc rebase: describe the priority of published work Philip Oakley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2F59222ECBA14673815BF42E6A7CE5A5@PhilipOakley \
    --to=philipoakley@iee.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox