git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] git-gui: Add support of SHA256 repo
Date: Wed, 16 Jul 2025 19:38:34 +0200	[thread overview]
Message-ID: <2a7f20ef-ad7b-47b5-9c3a-71fbdd11e756@kdbg.org> (raw)
In-Reply-To: <20250716073227.11486-1-tiwai@suse.de>

Am 16.07.25 um 09:32 schrieb Takashi Iwai:
> Here is the v3 patch for git-gui to support SHA256 repos.
> I put a preliminary patch to clean up $null_sha1 in addition to the
> correction / update of v2 patch.

Thanks, queued.

I applied the following fixups: an obvious typo-fix in a comment and use
of our wrapper function `git` instead of plain Tcl `exec git`.

diff --git a/git-gui.sh b/git-gui.sh
index c437980927fd..523e4df8069a 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -1298,8 +1298,8 @@ if {[catch {
 	set picked 1
 }
 
-# Use object format as hash algorightm (either "sha1" or "sha256")
-set hashalgorithm [exec git rev-parse --show-object-format]
+# Use object format as hash algorithm (either "sha1" or "sha256")
+set hashalgorithm [git rev-parse --show-object-format]
 if {$hashalgorithm eq "sha1"} {
 	set hashlength 40
 } elseif {$hashalgorithm eq "sha256"} {


  parent reply	other threads:[~2025-07-16 17:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16  7:32 [PATCH v3 0/2] git-gui: Add support of SHA256 repo Takashi Iwai
2025-07-16  7:32 ` [PATCH v3 1/2] git-gui: Replace null_sha1 with nullid Takashi Iwai
2025-07-16  7:32 ` [PATCH v3 2/2] git-gui: Add support of SHA256 repo Takashi Iwai
2025-07-16 17:38 ` Johannes Sixt [this message]
2025-07-17  7:03   ` [PATCH v3 0/2] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a7f20ef-ad7b-47b5-9c3a-71fbdd11e756@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).