From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Ken Matsui" <ken@kmatsui.me>, git@vger.kernel.org
Cc: "Matheus Tavares" <matheus.tavb@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Jonathan Tan" <jonathantanmy@google.com>,
"Elijah Newren" <newren@gmail.com>,
"Patrick Steinhardt" <ps@pks.im>,
"Victoria Dye" <vdye@github.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Glen Choo" <glencbz@gmail.com>
Subject: Re: [PATCH] config: support remote name in includeIf.hasconfig condition
Date: Sun, 20 Oct 2024 17:33:37 +0200 [thread overview]
Message-ID: <2a9a4371-958f-491e-b78b-6d4da51483f2@app.fastmail.com> (raw)
In-Reply-To: <20241020152323.90543-1-ken@kmatsui.me>
Hi
On Sun, Oct 20, 2024, at 17:23, Ken Matsui wrote:
> Before this patch, includeIf.hasconfig only accepted remote.*.url,
The conventional description of the current state of the code, without
this patch, is the present tense. What the patch does uses the
imperative mood. E.g.
includeIf.hasconfig only accepts remote.*.url
See Documentation/SubmittingPatches, “present-tense” and
“imperative-mood”.
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-10-20 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 15:23 [PATCH] config: support remote name in includeIf.hasconfig condition Ken Matsui
2024-10-20 15:33 ` Kristoffer Haugsbakk [this message]
2024-10-20 15:43 ` Ken Matsui
2024-10-20 16:01 ` [PATCH v2] " Ken Matsui
2024-10-20 16:21 ` Ramsay Jones
2024-10-20 17:18 ` Ken Matsui
2024-10-20 17:30 ` Ken Matsui
2024-10-20 17:32 ` [PATCH v3] " Ken Matsui
2024-11-06 13:30 ` Ken Matsui
2024-12-03 7:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a9a4371-958f-491e-b78b-6d4da51483f2@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=glencbz@gmail.com \
--cc=jonathantanmy@google.com \
--cc=ken@kmatsui.me \
--cc=martin.agren@gmail.com \
--cc=matheus.tavb@gmail.com \
--cc=newren@gmail.com \
--cc=ps@pks.im \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).