git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Antonio García Domínguez" <nyoescape@gmail.com>
To: git@vger.kernel.org
Subject: "add -p" + filenames with UTF-8 multibyte characters = "No changes"
Date: Sun, 15 Feb 2009 19:40:11 +0100	[thread overview]
Message-ID: <2b8265360902151040t49711942udd4862cc9df01da5@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Hello all,

I seem to have run into a bug in "add -p" and "add -i" when trying to
stage diff hunks in tracked files with UTF-8 multibyte characters
(such as "á"). If I add "á", commit, then modify it and try to run
"add -p" on it, Git reports "No changes". "add -i" doesn't do
anything, either.

I've switched to 1.6.2.rc0.90.g0753 and the problem persists. If it
helps, I've attached a small shell script with a minimal recipe for
triggering the bug.

This should incorrectly report "No changes":
./test-accents.sh

And this should work fine:
FILE=a ./test-accents.sh

-Antonio

[-- Attachment #2: test-accents.sh --]
[-- Type: application/x-sh, Size: 185 bytes --]

             reply	other threads:[~2009-02-15 18:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-15 18:40 Antonio García Domínguez [this message]
2009-02-15 18:59 ` "add -p" + filenames with UTF-8 multibyte characters = "No changes" Teemu Likonen
     [not found]   ` <2b8265360902151100n2eca0182odf9543c1dd8a7f98@mail.gmail.com>
2009-02-15 19:11     ` Teemu Likonen
2009-02-16  3:36       ` Jeff King
2009-02-16  4:00         ` Junio C Hamano
2009-02-17  7:02           ` [PATCH] git-add -i/-p: learn to unwrap C-quoted paths Junio C Hamano
2009-02-17  8:09             ` Teemu Likonen
2009-02-16  5:13         ` "add -p" + filenames with UTF-8 multibyte characters = "No changes" Teemu Likonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b8265360902151040t49711942udd4862cc9df01da5@mail.gmail.com \
    --to=nyoescape@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).