git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ervion <ervion@cryptolab.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>, jch2355@gmail.com
Subject: Re: Https password present in git output
Date: Thu, 14 Jul 2016 01:36:52 +0300	[thread overview]
Message-ID: <2bd57007f21ab1154d3bcc1e9bc8664e@cryptolab.net> (raw)
In-Reply-To: <CAPc5daXq-WBEYTyi2M7kMoZtQCYgucCRQ=GFVt8U_H_vRYyZPw@mail.gmail.com>


I completely agree that it is not a head-on-fire kind of problem, there 
are ways to avoid it.
Simply nice to have.

It is in fact the case, that git fetch output is scrubbed, sorry I did 
not notice previously.
But (on my device: git version 2.9.0 arch linux) git push is not.
$ git push origin --all

Results in:
/---/
To https://username:password@domeen.com/git/repo.git
    xxxxxxx..zzzzzzz  master -> master

On 13.07.2016 21:16, Junio C Hamano wrote:
> On Wed, Jul 13, 2016 at 11:09 AM, Junio C Hamano <gitster@pobox.com> 
> wrote:
>> ervion <ervion@cryptolab.net> writes:
>> 
>>> Sometimes using ssh is not possible and saving https password in 
>>> plain
>>> text to disk may be desireable
>>> (in case of encrypted disk it would be equivalent security with
>>> caching password in memory).
>>> 
>>> One possibility for this in git is to save remote in the
>>> https://username:password@domain.com/repo.git format.
>> 
>> Wasn't netrc support added exactly because users do not want to do
>> this?
> 
> Interesting. Even with "auth in URL", I seem to get this:
> 
> $ git fetch -v -v https://gitster:pass@github.com/git/git  
> refs/tags/v2.9.1
> From https://github.com/git/git
>  * tag               v2.9.1     -> FETCH_HEAD
> 
> Notice that "From $URL" has the userinfo (3.2.1 in RFC 3986) scrubbed.
> 
> If you are seeing somewhere we forgot to scrub userinfo in a similar 
> way in
> the output, we should. Where do you see "present in git OUTPUT" as you
> said in the subject? What command with what options exactly and in what
> part of the output?
> 
> Thanks.

  reply	other threads:[~2016-07-13 23:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 17:26 Https password present in git output ervion
2016-07-13 18:09 ` Junio C Hamano
2016-07-13 18:16   ` Junio C Hamano
2016-07-13 22:36     ` ervion [this message]
2016-07-13 23:36       ` Jeff King
2016-07-13 18:16 ` Dennis Kaarsemaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bd57007f21ab1154d3bcc1e9bc8664e@cryptolab.net \
    --to=ervion@cryptolab.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jch2355@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).