From: "Jonas Fonseca" <jonas.fonseca@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] shortlog: initialize nongit variable
Date: Tue, 25 Mar 2008 20:58:50 +0100 [thread overview]
Message-ID: <2c6b72b30803251258j313e0d94qe290b8b7c7b377f0@mail.gmail.com> (raw)
In-Reply-To: <20080325160356.GC6506@neumann>
2008/3/25 SZEDER Gábor <szeder@ira.uka.de>:
> However, it might be better to let setup_git_directory_gently() set
> *nongit_ok to 0 if we are in a git repository. Patch appended.
As the one responsible for introducing this bug into shortlog, I can only agree.
> builtin-bundle.c | 2 +-
> builtin-config.c | 2 +-
> builtin-diff-files.c | 2 +-
> builtin-ls-remote.c | 2 +-
> git.c | 2 +-
> setup.c | 8 ++++++++
> 6 files changed, 13 insertions(+), 5 deletions(-)
git grep reveals that builtin-{apply,diff}.c, help.c and var.c also
belongs on this list.
--
Jonas Fonseca
next prev parent reply other threads:[~2008-03-25 19:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 14:46 [PATCH] shortlog: initialize nongit variable SZEDER Gábor
2008-03-25 15:39 ` Nguyen Thai Ngoc Duy
2008-03-25 16:03 ` SZEDER Gábor
2008-03-25 19:58 ` Jonas Fonseca [this message]
2008-03-25 21:06 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6b72b30803251258j313e0d94qe290b8b7c7b377f0@mail.gmail.com \
--to=jonas.fonseca@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).