git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonas Fonseca <fonseca@diku.dk>
To: Stefan Karpinski <stefan.karpinski@gmail.com>
Cc: Brian Gernhardt <benji@silverinsanity.com>,
	Ted Pavlic <ted@tedpavlic.com>, git <git@vger.kernel.org>
Subject: Re: [ANNOUNCE] tig-0.14
Date: Tue, 10 Feb 2009 21:41:21 +0100	[thread overview]
Message-ID: <2c6b72b30902101241p67a0e1e9u60c8033c4a03260c@mail.gmail.com> (raw)
In-Reply-To: <d4bc1a2a0902101129y22224c89y144b223e7d7dd463@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

On Tue, Feb 10, 2009 at 20:29, Stefan Karpinski
<stefan.karpinski@gmail.com> wrote:
> On Tue, Feb 10, 2009 at 11:07 AM, Brian Gernhardt
> <benji@silverinsanity.com> wrote:
>>
>> OS 10.5.6's Terminal.app, with TERM=xterm-color
>> I have no .tigrc
>
> Ditto. Same bug. Completely vanilla tig setup. OS X Leopard,
> tig-0.14-9-gd06137e, TERM=xterm-color.

Looks like there might be a pattern and I might have an excuse to go
knock on the door of one of my "Mac" friends. ;) However, first I
would kindly ask if one of you have time to test the attached patch.

Thanks both of you and sorry for the inconvenience.

-- 
Jonas Fonseca

[-- Attachment #2: 0001-Fix-regression-where-a-line-was-not-cleared-when-not.patch --]
[-- Type: text/x-diff, Size: 828 bytes --]

From 3670b9f20c49c46c6418d7dbcce8265b2fe8a853 Mon Sep 17 00:00:00 2001
From: Jonas Fonseca <fonseca@diku.dk>
Date: Tue, 10 Feb 2009 21:33:18 +0100
Subject: [PATCH] Fix regression where a line was not cleared when not selected anymore

Introduced in 273c28df2aa5cc0d122b1a0f3c0014a56ab8c392 (Tree view: make
drawing more smooth by using the dirty flag).
---
 tig.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tig.c b/tig.c
index 7072094..02f4bd8 100644
--- a/tig.c
+++ b/tig.c
@@ -2055,7 +2055,7 @@ draw_view_line(struct view *view, unsigned int lineno)
 	line = &view->line[view->offset + lineno];
 
 	wmove(view->win, lineno, 0);
-	if (line->cleareol)
+	if (line->cleareol || (line->selected && !selected))
 		wclrtoeol(view->win);
 	view->col = 0;
 	view->curline = line;
-- 
1.6.1.1.347.g3f81d


  reply	other threads:[~2009-02-10 20:42 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 20:44 [ANNOUNCE] tig-0.14 Jonas Fonseca
2009-02-06 10:49 ` bill lam
2009-02-06 14:29   ` Jonas Fonseca
2009-02-06 15:25     ` Sitaram Chamarty
2009-02-08 10:07       ` Jonas Fonseca
2009-02-11 16:05         ` showing SHA1 of parent commit in tig [was " Sitaram Chamarty
2009-02-12  1:19           ` Jonas Fonseca
2009-02-12  3:28             ` Sitaram Chamarty
2009-02-06 19:15 ` Jeff King
2009-02-06 22:10   ` Jonas Fonseca
2009-02-06 22:53     ` Jakub Narebski
2009-02-08 10:13       ` Jonas Fonseca
2009-02-07  7:10     ` Jeff King
2009-02-07  7:28       ` Junio C Hamano
2009-02-07  8:55         ` david
2009-02-08 10:47           ` Jonas Fonseca
2009-02-08 10:55             ` Jonas Fonseca
2009-02-08 11:06               ` Jeff King
2009-02-08 11:52                 ` Jonas Fonseca
2009-02-07 11:26         ` Jeff King
2009-02-08 10:31       ` Jonas Fonseca
2009-02-08 11:00         ` Jeff King
2009-02-08 11:49           ` Jonas Fonseca
2009-02-07  2:48 ` Mikael Magnusson
2009-02-09 22:07 ` Peter Baumann
2009-02-09 22:22   ` Jeff King
2009-02-09 22:30     ` Peter Baumann
2009-02-10 18:42       ` Jonas Fonseca
2009-02-10 21:23         ` Jari Aalto
2009-02-10 13:29 ` Ted Pavlic
2009-02-10 18:29   ` Jonas Fonseca
2009-02-10 19:07     ` Brian Gernhardt
2009-02-10 19:29       ` Stefan Karpinski
2009-02-10 20:41         ` Jonas Fonseca [this message]
2009-02-10 20:49           ` Brian Gernhardt
2009-02-10 21:13             ` Jonas Fonseca
2009-02-10 21:18               ` Brian Gernhardt
2009-02-11 14:06             ` Ted Pavlic
2009-02-12  1:30               ` Jonas Fonseca
2009-02-11 14:19           ` Ted Pavlic
2009-02-20 17:24           ` Ted Pavlic
2009-02-20 18:34             ` Jonas Fonseca
2009-02-20 20:36               ` Ted Pavlic
2009-02-20 23:31                 ` Jonas Fonseca
2009-02-25 21:54                 ` Jonas Fonseca
2009-02-11 14:03     ` Ted Pavlic
2009-02-11 14:12       ` Ted Pavlic
2009-02-11 17:47 ` Ted Pavlic
2009-02-12  1:08   ` Jonas Fonseca
2009-02-12 21:48 ` Tilo Schwarz
2009-02-12 22:24   ` Jonas Fonseca
2009-02-12 23:14     ` Tilo Schwarz
2009-02-15 23:47       ` Jonas Fonseca
2009-02-16  1:33         ` Sitaram Chamarty
2009-02-16 12:10           ` Jonas Fonseca
2009-02-16 15:14             ` Sitaram Chamarty
2009-02-16 15:25               ` Thomas Adam
2009-02-16 19:52                 ` Jonas Fonseca
2009-02-17  7:47                   ` Marco Costalba
2009-02-16 21:12         ` Tilo Schwarz
2009-02-20 23:35           ` Jonas Fonseca
2009-02-21 17:35             ` Tilo Schwarz
2009-02-21 17:41               ` Jonas Fonseca
2009-02-21 20:18                 ` Tilo Schwarz
2009-02-16 21:55         ` Tilo Schwarz
2009-02-13  2:31     ` bill lam
2009-02-13 23:57       ` Jonas Fonseca
2009-02-14  3:31         ` bill lam
2009-02-15 23:22           ` Jonas Fonseca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c6b72b30902101241p67a0e1e9u60c8033c4a03260c@mail.gmail.com \
    --to=fonseca@diku.dk \
    --cc=benji@silverinsanity.com \
    --cc=git@vger.kernel.org \
    --cc=stefan.karpinski@gmail.com \
    --cc=ted@tedpavlic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).