* [tig PATCH] add missing NULL in blame_grep
@ 2009-02-20 3:23 Jeff King
2009-02-20 14:36 ` Jonas Fonseca
0 siblings, 1 reply; 2+ messages in thread
From: Jeff King @ 2009-02-20 3:23 UTC (permalink / raw)
To: Jonas Fonseca; +Cc: git
Commit 436674f introduced a grep_text utility function which
takes a NULL-terminated list; the callsite in blame_grep
forgot to put in a NULL, leading to segmentation faults.
Signed-off-by: Jeff King <peff@peff.net>
---
tig.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tig.c b/tig.c
index 5acb398..1de732c 100644
--- a/tig.c
+++ b/tig.c
@@ -4595,6 +4595,7 @@ blame_grep(struct view *view, struct line *line)
commit ? commit->id : "",
commit && opt_author ? commit->author : "",
commit && opt_date ? mkdate(&commit->time) : "",
+ NULL
};
return grep_text(view, text);
--
1.6.2.rc1.242.g8d690
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [tig PATCH] add missing NULL in blame_grep
2009-02-20 3:23 [tig PATCH] add missing NULL in blame_grep Jeff King
@ 2009-02-20 14:36 ` Jonas Fonseca
0 siblings, 0 replies; 2+ messages in thread
From: Jonas Fonseca @ 2009-02-20 14:36 UTC (permalink / raw)
To: Jeff King; +Cc: git
On Fri, Feb 20, 2009 at 04:23, Jeff King <peff@peff.net> wrote:
> Commit 436674f introduced a grep_text utility function which
> takes a NULL-terminated list; the callsite in blame_grep
> forgot to put in a NULL, leading to segmentation faults.
Thanks for bailing me out yet again. :)
--
Jonas Fonseca
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-20 14:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-20 3:23 [tig PATCH] add missing NULL in blame_grep Jeff King
2009-02-20 14:36 ` Jonas Fonseca
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).