From: Jonas Fonseca <jonas.fonseca@gmail.com>
To: tilo@tilo-schwarz.de
Cc: git@vger.kernel.org
Subject: Re: [tig PATCH 0/1] Make height of split view configurable
Date: Wed, 25 Feb 2009 23:17:25 +0100 [thread overview]
Message-ID: <2c6b72b30902251417s2f166910w4a47a2d1a43aef93@mail.gmail.com> (raw)
In-Reply-To: <cover.1235338009.git.tilo@tilo-schwarz.de>
On Mon, Feb 23, 2009 at 23:24, <tilo@tilo-schwarz.de> wrote:
> Rationale: On a large display with many rows it would be nice to be
> able to configure the heights of the views in the split view. For
> example, I like to have the lower diff view be 90% of the total
> view height.
>
> As it is, the patch lets the height of the lower view be configurable.
> Is it may be better to configure the height of the upper view?
I don't know, the way you have done it seems reasonable.
> Any input on variable nameing, code style etc. of course welcome.
Very, very clean and nicely done with the reusing of the parse/apply
step code. Thanks.
--
Jonas Fonseca
prev parent reply other threads:[~2009-02-25 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-23 22:24 [tig PATCH 0/1] Make height of split view configurable tilo
2009-02-23 22:24 ` [PATCH 1/1] " tilo
2009-02-25 22:17 ` Jonas Fonseca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c6b72b30902251417s2f166910w4a47a2d1a43aef93@mail.gmail.com \
--to=jonas.fonseca@gmail.com \
--cc=git@vger.kernel.org \
--cc=tilo@tilo-schwarz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).