From: Jon Seymour <jon.seymour@gmail.com>
To: Junio C Hamano <junkio@cox.net>
Cc: torvalds@osdl.org, git@vger.kernel.org
Subject: Re: [PATCH] Fixlet for argument parsing in rev-list.
Date: Tue, 5 Jul 2005 19:14:32 +1000 [thread overview]
Message-ID: <2cfc40320507050214154c0fff@mail.gmail.com> (raw)
In-Reply-To: <7vpstxg02q.fsf@assigned-by-dhcp.cox.net>
I ack the patch, though --show-breaks could use the same treatment.
jon.
On 7/5/05, Junio C Hamano <junkio@cox.net> wrote:
> The --merge-order flag does not take parameter so there is no
> point doing strncmp with the length.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> ---
>
> rev-list.c | 2 +-
> 1 file changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rev-list.c b/rev-list.c
> --- a/rev-list.c
> +++ b/rev-list.c
> @@ -462,7 +462,7 @@ int main(int argc, char **argv)
> limited = 1;
> continue;
> }
> - if (!strncmp(arg, "--merge-order", 13)) {
> + if (!strcmp(arg, "--merge-order")) {
> merge_order = 1;
> continue;
> }
> ------------------------------------------------
>
>
--
homepage: http://www.zeta.org.au/~jon/
blog: http://orwelliantremors.blogspot.com/
prev parent reply other threads:[~2005-07-05 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-05 7:54 [PATCH] Fixlet for argument parsing in rev-list Junio C Hamano
2005-07-05 9:14 ` Jon Seymour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cfc40320507050214154c0fff@mail.gmail.com \
--to=jon.seymour@gmail.com \
--cc=git@vger.kernel.org \
--cc=jon@blackcubes.dyndns.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).