* [PATCH] Fixlet for argument parsing in rev-list.
@ 2005-07-05 7:54 Junio C Hamano
2005-07-05 9:14 ` Jon Seymour
0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2005-07-05 7:54 UTC (permalink / raw)
To: torvalds; +Cc: jon.seymour, git
The --merge-order flag does not take parameter so there is no
point doing strncmp with the length.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
rev-list.c | 2 +-
1 file changed, 1 insertions(+), 1 deletions(-)
diff --git a/rev-list.c b/rev-list.c
--- a/rev-list.c
+++ b/rev-list.c
@@ -462,7 +462,7 @@ int main(int argc, char **argv)
limited = 1;
continue;
}
- if (!strncmp(arg, "--merge-order", 13)) {
+ if (!strcmp(arg, "--merge-order")) {
merge_order = 1;
continue;
}
------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fixlet for argument parsing in rev-list.
2005-07-05 7:54 [PATCH] Fixlet for argument parsing in rev-list Junio C Hamano
@ 2005-07-05 9:14 ` Jon Seymour
0 siblings, 0 replies; 2+ messages in thread
From: Jon Seymour @ 2005-07-05 9:14 UTC (permalink / raw)
To: Junio C Hamano; +Cc: torvalds, git
I ack the patch, though --show-breaks could use the same treatment.
jon.
On 7/5/05, Junio C Hamano <junkio@cox.net> wrote:
> The --merge-order flag does not take parameter so there is no
> point doing strncmp with the length.
>
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> ---
>
> rev-list.c | 2 +-
> 1 file changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/rev-list.c b/rev-list.c
> --- a/rev-list.c
> +++ b/rev-list.c
> @@ -462,7 +462,7 @@ int main(int argc, char **argv)
> limited = 1;
> continue;
> }
> - if (!strncmp(arg, "--merge-order", 13)) {
> + if (!strcmp(arg, "--merge-order")) {
> merge_order = 1;
> continue;
> }
> ------------------------------------------------
>
>
--
homepage: http://www.zeta.org.au/~jon/
blog: http://orwelliantremors.blogspot.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-05 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-05 7:54 [PATCH] Fixlet for argument parsing in rev-list Junio C Hamano
2005-07-05 9:14 ` Jon Seymour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).