* [PATCH] fetch: do not create ref from empty name
2009-06-17 12:08 error: * Ignoring funny ref 'refs/heads/' locally Jon Seymour
@ 2009-06-17 13:38 ` Clemens Buchacher
0 siblings, 0 replies; 2+ messages in thread
From: Clemens Buchacher @ 2009-06-17 13:38 UTC (permalink / raw)
To: Jon Seymour; +Cc: Git Mailing List, Junio C Hamano
Previously, the refspec "<src>:" would be expanded to
"<src>:refs/heads/". Instead, treat an empty <dst> just like refspecs
without a colon.
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
---
On Wed, Jun 17, 2009 at 10:08:25PM +1000, Jon Seymour wrote:
> Can someone tell me why this happens?
>
> error: * Ignoring funny ref 'refs/heads/' locally
This fixes it.
Note that "git fetch origin :" is short for "git fetch origin
HEAD", which stores the remote HEAD in FETCH_HEAD. You probably want "git
fetch origin", without an explicit refspec, which defaults to "git fetch
origin 'refs/heads/*:refs/remotes/origin/*'", i.e. store remote branches in
the namespace for tracking branches.
Clemens
remote.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/remote.c b/remote.c
index 08a5964..99e7797 100644
--- a/remote.c
+++ b/remote.c
@@ -1263,7 +1263,7 @@ struct ref *get_remote_ref(const struct ref *remote_refs, const char *name)
static struct ref *get_local_ref(const char *name)
{
- if (!name)
+ if (!name || name[0] == '\0')
return NULL;
if (!prefixcmp(name, "refs/"))
--
1.6.3.1.147.g637c3
^ permalink raw reply related [flat|nested] 2+ messages in thread