git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 2/4] diffcore-pickaxe: micro-optimize has_match() function
Date: Wed, 25 Feb 2009 22:52:04 -0800	[thread overview]
Message-ID: <2dbd5fcdfd9da5f8fbbab5b0928b361d8119c97b.1235629933.git.gitster@pobox.com> (raw)
In-Reply-To: <cover.1235629933.git.gitster@pobox.com>

When we are looking at an event that creates (or removes) a path, we only
need to see if the created (or removed) blob has an instance of the needle
we are looking for.  There is no need to count, once we know there is one.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 diffcore-pickaxe.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/diffcore-pickaxe.c b/diffcore-pickaxe.c
index d27e725..007b39c 100644
--- a/diffcore-pickaxe.c
+++ b/diffcore-pickaxe.c
@@ -5,7 +5,8 @@
 #include "diff.h"
 #include "diffcore.h"
 
-static unsigned int count_match(struct diff_filespec *one,
+static unsigned int count_match(int one_or_more,
+				struct diff_filespec *one,
 				const char *needle, unsigned long len,
 				regex_t *regexp)
 {
@@ -30,6 +31,8 @@ static unsigned int count_match(struct diff_filespec *one,
 			data += regmatch.rm_so;
 			if (*data) data++;
 			cnt++;
+			if (one_or_more)
+				break;
 		}
 
 	} else { /* Classic exact string match */
@@ -41,6 +44,8 @@ static unsigned int count_match(struct diff_filespec *one,
 			if (!memcmp(needle, data + offset, len)) {
 				offset += len - 1;
 				cnt++;
+				if (one_or_more)
+					break;
 			}
 		}
 	}
@@ -52,15 +57,15 @@ static int has_match(struct diff_filespec *one,
 		     const char *needle, unsigned long len,
 		     regex_t *regexp)
 {
-	return !!count_match(one, needle, len, regexp);
+	return count_match(1, one, needle, len, regexp);
 }
 
 static int has_different_matches(struct diff_filepair *p,
 				 const char *needle, unsigned long len,
 				 regex_t *regexp)
 {
-	return (count_match(p->one, needle, len, regexp)
-		!= count_match(p->two, needle, len, regexp));
+	return (count_match(0, p->one, needle, len, regexp)
+		!= count_match(0, p->two, needle, len, regexp));
 
 }
 
-- 
1.6.2.rc2.91.gf9a36

  parent reply	other threads:[~2009-02-26  6:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26  6:52 [PATCH 0/4] Pickaxe search clean-up and optimization Junio C Hamano
2009-02-26  6:52 ` [PATCH 1/4] diffcore-pickaxe: refactor diffcore_pickaxe() Junio C Hamano
2009-02-27 23:58   ` René Scharfe
2009-02-26  6:52 ` Junio C Hamano [this message]
2009-02-26  6:52 ` [PATCH 3/4] diffcore-pickaxe: further refactor count_match() Junio C Hamano
2009-02-26  7:23   ` Kjetil Barvik
2009-02-28  1:13   ` René Scharfe
2009-02-28  1:25     ` Junio C Hamano
2009-02-28  6:08       ` Junio C Hamano
2009-02-28 13:10         ` René Scharfe
2009-02-28 17:40           ` Junio C Hamano
2009-02-28 18:15             ` René Scharfe
2009-02-28 19:16             ` [PATCH] import memmem() with linear complexity from Gnulib René Scharfe
2009-02-28 22:44               ` Mike Hommey
2009-03-01  3:41                 ` Jeff King
2009-03-01 11:15                   ` René Scharfe
2009-03-01 18:55                     ` René Scharfe
2009-03-01  7:31           ` [PATCH 3/4] diffcore-pickaxe: further refactor count_match() Junio C Hamano
2009-03-01 10:53             ` René Scharfe
2009-02-26  6:52 ` [PATCH 4/4] diffcore-pickaxe: optimize by trimming common initial and trailing parts Junio C Hamano
2009-02-26  9:05   ` Junio C Hamano
2009-03-02 23:00 ` [PATCH 1/2] diffcore-pickaxe: use memmem() René Scharfe
2009-03-02 23:19   ` [PATCH 2/2] optimize compat/ memmem() René Scharfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dbd5fcdfd9da5f8fbbab5b0928b361d8119c97b.1235629933.git.gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).