From: Sitaram Chamarty <sitaramc@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Documentation: update description of shell aliases
Date: Thu, 2 Jul 2009 06:27:19 +0530 [thread overview]
Message-ID: <2e24e5b90907011757r498b8c52v4cf5dfb7016bf8b5@mail.gmail.com> (raw)
In-Reply-To: <7v7hysl0x8.fsf@alter.siamese.dyndns.org>
On Wed, Jul 1, 2009 at 11:51 PM, Junio C Hamano<gitster@pobox.com> wrote:
> Sitaram Chamarty <sitaramc@gmail.com> writes:
>
>> Aliases that invoke shell commands start from the top-level directory,
>> but this was not documented.
>
> Could you please also think if it is worth mentioning what happens when
> you do not even have a top-level directory? I.e. in a bare repository.
Yes I thought about it. I decided not to add that because
it is:
- not common enough (how many new users fiddle in bare
repos?)
- not surprising enough (I did test it; it just uses the
current -- bare -- directory, as even a new user would
expect)
(In contrast, the part I added _was_ somewhat surprising.)
And if we go that far, why not also document what happens
with various combinations of $PWD,$GIT_DIR and
$GIT_WORK_TREE? I did not get a chance to test those, but
if you think we should add those also, I will do so and
document what happens.
I just think it may be a bit overkill, but if you think it's
not, and it adds value, just say so and I will test and
document it.
next prev parent reply other threads:[~2009-07-02 0:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 16:00 [PATCH] Documentation: update description of shell aliases Sitaram Chamarty
2009-07-01 18:21 ` Junio C Hamano
2009-07-02 0:57 ` Sitaram Chamarty [this message]
2009-07-02 7:21 ` Andreas Ericsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e24e5b90907011757r498b8c52v4cf5dfb7016bf8b5@mail.gmail.com \
--to=sitaramc@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).