From: Alex Galvin <agalvin@comqi.com>
To: Junio C Hamano <gitster@pobox.com>,
Alex Galvin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Alex Galvin <alex.v.galvin@gmail.com>
Subject: Re: [PATCH v2] git-svn: mention `svn:global-ignores` in help+docs
Date: Wed, 14 Aug 2024 13:53:57 -0400 [thread overview]
Message-ID: <2edfbfad-bfae-4fe1-8f26-4310fc54b2a0@comqi.com> (raw)
In-Reply-To: <xmqqzfpg2gup.fsf@gitster.g>
On 2024-08-13 6:33 p.m., Junio C Hamano wrote:
>> diff --git a/git-svn.perl b/git-svn.perl
>> index a2a46608c9b..d8dc485e50d 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -219,11 +219,11 @@ my %cmd = (
>> "Set an SVN repository to a git tree-ish",
>> { 'stdin' => \$_stdin, %cmt_opts, %fc_opts, } ],
>> 'create-ignore' => [ \&cmd_create_ignore,
>> - 'Create a .gitignore persvn:ignore',
>> + "Create a .gitignore per directory with an SVN ignore property",
> Hmph. Is it intentional that this "create" side uses a single
> property while ...
> ... the other "show" side talks about "ignore properties" (plural),
> implying that both svn:ignore and svn:global-ignores may get
> involved?
I was trying to be precise that the create command makes one .gitignore
file in each directory it visits, regardless if that directory only has
one of the attributes or both. Would using "any SVN ignore property"
instead of "a SVN ignore property" make this clear?
Thanks,
Alex
next prev parent reply other threads:[~2024-08-14 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 22:06 [PATCH] git-svn: mention `svn:globalignores` in help+docs Alex Galvin via GitGitGadget
2024-08-13 17:36 ` Junio C Hamano
2024-08-13 19:05 ` Alex Galvin
2024-08-13 19:55 ` [PATCH v2] git-svn: mention `svn:global-ignores` " Alex Galvin via GitGitGadget
2024-08-13 22:33 ` Junio C Hamano
2024-08-14 17:53 ` Alex Galvin [this message]
2024-08-14 18:55 ` Junio C Hamano
2024-08-14 20:03 ` [PATCH v3] " Alex Galvin via GitGitGadget
2024-08-14 22:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2edfbfad-bfae-4fe1-8f26-4310fc54b2a0@comqi.com \
--to=agalvin@comqi.com \
--cc=alex.v.galvin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).